Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp

2013-06-08 Thread Eric Sunshine
On Sat, Jun 8, 2013 at 10:57 PM, Jeff King wrote: > On Sat, Jun 08, 2013 at 08:38:56PM +0200, Matthieu Moy wrote: > >> Célestin Matte writes: >> >> > In Perl, '\n' is not a newline, but instead a literal backslash followed >> > by an >> > "n". As the output of "rev-list --first-parent" is line-o

Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp

2013-06-08 Thread Eric Sunshine
On Sat, Jun 8, 2013 at 9:35 AM, Célestin Matte wrote: > In Perl, '\n' is not a newline, but instead a literal backslash followed by an > "n". As the output of "rev-list --first-parent" is line-oriented, what we want > here is a newline. > > Signed-off-by: Célestin Matte > Signed-off-by: Matthieu

Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp

2013-06-08 Thread Jeff King
On Sat, Jun 08, 2013 at 08:38:56PM +0200, Matthieu Moy wrote: > Célestin Matte writes: > > > In Perl, '\n' is not a newline, but instead a literal backslash followed by > > an > > "n". As the output of "rev-list --first-parent" is line-oriented, what we > > want > > here is a newline. > > Thi

Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp

2013-06-08 Thread Célestin Matte
Le 08/06/2013 20:38, Matthieu Moy a écrit :> This is right, but the code actually worked the way it was. I'm not > sure, but my understanding is that '\n' is the string "backslash > followed by n", but interpreted as a regexp, it is a newline. > > The new code looks better than the old one, but the

Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp

2013-06-08 Thread Matthieu Moy
Célestin Matte writes: > In Perl, '\n' is not a newline, but instead a literal backslash followed by an > "n". As the output of "rev-list --first-parent" is line-oriented, what we want > here is a newline. This is right, but the code actually worked the way it was. I'm not sure, but my understan

[PATCH] git-remote-mediawiki: Fix a bug in a regexp

2013-06-08 Thread Célestin Matte
In Perl, '\n' is not a newline, but instead a literal backslash followed by an "n". As the output of "rev-list --first-parent" is line-oriented, what we want here is a newline. Signed-off-by: Célestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl |2 +- 1