Re: [PATCH] git-p4: remove obsolete version check

2017-06-04 Thread brian m. carlson
On Sat, Jun 03, 2017 at 06:55:22PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Sat, Jun 3, 2017 at 3:31 PM, Jakub Wilk wrote: > > The file is syntactically correct only in Python >= 2.6, so the > > version check never does anything. > > [CC-ing Eric who added that check] > > Your commit message d

Re: [PATCH] git-p4: remove obsolete version check

2017-06-03 Thread Ævar Arnfjörð Bjarmason
On Sat, Jun 3, 2017 at 3:31 PM, Jakub Wilk wrote: > The file is syntactically correct only in Python >= 2.6, so the > version check never does anything. [CC-ing Eric who added that check] Your commit message doesn't give an example of this, but with e.g. python 2.0 you get: File "git-p4.p

[PATCH] git-p4: remove obsolete version check

2017-06-03 Thread Jakub Wilk
The file is syntactically correct only in Python >= 2.6, so the version check never does anything. Signed-off-by: Jakub Wilk --- git-p4.py | 4 1 file changed, 4 deletions(-) diff --git a/git-p4.py b/git-p4.py index 8d151da91..4278cd9d4 100755 --- a/git-p4.py +++ b/git-p4.py @@ -8,10 +8,6