Miguel Torroja writes:
> I've just sent in reply to your previous e-mail three different patches.
>
> * The first patch is just to show some broken tests,
> * Second patch is to fix the original issue I had (the one that
> initiated this thread)
> * Third patch is the one that filters out "info"
Thanks,
I've just sent in reply to your previous e-mail three different patches.
* The first patch is just to show some broken tests,
* Second patch is to fix the original issue I had (the one that
initiated this thread)
* Third patch is the one that filters out "info" messages in p4CmdList
(this
Miguel Torroja writes:
> The motivation for setting skip_info default to True is because any
> extra message output by a p4 trigger to stdout, seems to be reported
> as {'code':'info'} when the p4 command output is marshalled.
>
> I though it was the less intrusive way to filter out the verbose
The motivation for setting skip_info default to True is because any
extra message output by a p4 trigger to stdout, seems to be reported
as {'code':'info'} when the p4 command output is marshalled.
I though it was the less intrusive way to filter out the verbose
server trigger scripts, as some co
On 11 July 2017 at 23:53, Miguel Torroja wrote:
> The option -G of p4 (python marshal output) gives more context about the
> data being output. That's useful when using the command "change -o" as
> we can distinguish between warning/error line and real change description.
>
> Some p4 triggers in t
The option -G of p4 (python marshal output) gives more context about the
data being output. That's useful when using the command "change -o" as
we can distinguish between warning/error line and real change description.
Some p4 triggers in the server side generate some warnings when
executed. Unfor
Hi Luke,
My bad as I didn't check that case.
It was p4CmdList as you said. the default value of the new field
skip_info (set to True) ignores any info messages. and the script is
waiting for a valid message.
If I set it to False, then it does return an info entry and it accepts
the submit change
On 3 July 2017 at 23:57, Miguel Torroja wrote:
> The option -G of p4 (python marshal output) gives more context about the
> data being output. That's useful when using the command "change -o" as
> we can distinguish between warning/error line and real change description.
>
> Some p4 triggers in th
The option -G of p4 (python marshal output) gives more context about the
data being output. That's useful when using the command "change -o" as
we can distinguish between warning/error line and real change description.
Some p4 triggers in the server side generate some warnings when
executed. Unfor
I changed the patch a little bit, first change is to ignore by default
any {'code':'info'} in p4CmdList (they are not exposed to the caller)
as those are the verbose messages from triggers (p4 Debug does show
them). the second change is to check the p4 trigger is really set in
the test (Lars sugges
On Fri, Jun 30, 2017 at 12:13 PM, Lars Schneider
wrote:
>
>> On 30 Jun 2017, at 11:41, Miguel Torroja wrote:
>>
>> On Fri, Jun 30, 2017 at 10:26 AM, Lars Schneider
>> wrote:
>>>
On 30 Jun 2017, at 00:46, miguel torroja wrote:
The option -G of p4 (python marshal output) gives more
> On 30 Jun 2017, at 11:41, Miguel Torroja wrote:
>
> On Fri, Jun 30, 2017 at 10:26 AM, Lars Schneider
> wrote:
>>
>>> On 30 Jun 2017, at 00:46, miguel torroja wrote:
>>>
>>> The option -G of p4 (python marshal output) gives more context about the
>>> data being output. That's useful when us
On Fri, Jun 30, 2017 at 10:26 AM, Lars Schneider
wrote:
>
>> On 30 Jun 2017, at 00:46, miguel torroja wrote:
>>
>> The option -G of p4 (python marshal output) gives more context about the
>> data being output. That's useful when using the command "change -o" as
>> we can distinguish between warni
> On 30 Jun 2017, at 00:46, miguel torroja wrote:
>
> The option -G of p4 (python marshal output) gives more context about the
> data being output. That's useful when using the command "change -o" as
> we can distinguish between warning/error line and real change description.
>
> Some p4 trigge
The Latest patch I sent was already the squashed version with the fix
to pass the tests.
Thanks,
On Fri, Jun 30, 2017 at 9:56 AM, Luke Diamand wrote:
> On 29 June 2017 at 23:41, miguel torroja wrote:
>> On Thu, Jun 29, 2017 at 8:59 AM, Luke Diamand wrote:
>>> On 28 June 2017 at 14:14, miguel t
On 29 June 2017 at 23:41, miguel torroja wrote:
> On Thu, Jun 29, 2017 at 8:59 AM, Luke Diamand wrote:
>> On 28 June 2017 at 14:14, miguel torroja wrote:
>>> Thanks Luke,
>>>
>>> regarding the error in t9800 (not ok 18 - unresolvable host in P4PORT
>>> should display error), for me it's very wei
The option -G of p4 (python marshal output) gives more context about the
data being output. That's useful when using the command "change -o" as
we can distinguish between warning/error line and real change description.
Some p4 triggers in the server side generate some warnings when
executed. Unfor
On Thu, Jun 29, 2017 at 8:59 AM, Luke Diamand wrote:
> On 28 June 2017 at 14:14, miguel torroja wrote:
>> Thanks Luke,
>>
>> regarding the error in t9800 (not ok 18 - unresolvable host in P4PORT
>> should display error), for me it's very weird too as it doesn't seem
>> to be related to this parti
On 28 June 2017 at 14:14, miguel torroja wrote:
> Thanks Luke,
>
> regarding the error in t9800 (not ok 18 - unresolvable host in P4PORT
> should display error), for me it's very weird too as it doesn't seem
> to be related to this particular change, as the patch changes are not
> exercised with t
Thanks Luke,
regarding the error in t9800 (not ok 18 - unresolvable host in P4PORT
should display error), for me it's very weird too as it doesn't seem
to be related to this particular change, as the patch changes are not
exercised with that test.
The test 21 in t9807 was precisely the new test a
On 28 June 2017 at 05:08, Junio C Hamano wrote:
> Miguel Torroja writes:
>
>> The option -G of p4 (python marshal output) gives more context about the
>> data being output. That's useful when using the command "change -o" as
>> we can distinguish between warning/error line and real change descrip
Miguel Torroja writes:
> The option -G of p4 (python marshal output) gives more context about the
> data being output. That's useful when using the command "change -o" as
> we can distinguish between warning/error line and real change description.
>
> Some p4 triggers in the server side generate
The option -G of p4 (python marshal output) gives more context about the
data being output. That's useful when using the command "change -o" as
we can distinguish between warning/error line and real change description.
Some p4 triggers in the server side generate some warnings when
executed. Unfor
23 matches
Mail list logo
