Re: [PATCH] git-p4: Handle p4 submit failure

Luke Diamand writes: > On 30/10/15 17:57, Junio C Hamano wrote: >> Etienne Girard writes: >> >>> Yes, however if `p4 submit` fails the corresponding "Command failed" >>> error message is displayed, and the p4 error message itself is >>> displayed if any. >>> Tthe script will also terminate succe

Re: [PATCH] git-p4: Handle p4 submit failure

On 30/10/15 17:57, Junio C Hamano wrote: Etienne Girard writes: Yes, however if `p4 submit` fails the corresponding "Command failed" error message is displayed, and the p4 error message itself is displayed if any. Tthe script will also terminate successfully if self.edit_template returns false

Re: [PATCH] git-p4: Handle p4 submit failure

Etienne Girard writes: > Yes, however if `p4 submit` fails the corresponding "Command failed" > error message is displayed, and the p4 error message itself is > displayed if any. > Tthe script will also terminate successfully if self.edit_template > returns false but it will exit with error code

Re: [PATCH] git-p4: Handle p4 submit failure

Hello, > Note: this time, you do not need to resend the patch; just > please let me know if you want me to do the equivalent of > the above while applying to make your murex address and name > appear as the author in "git log" and "git shortlog" output. I'd like my

Re: [PATCH] git-p4: Handle p4 submit failure

Etienne Girard writes: > Clean the workspace if p4_write_pipe raised SystemExit, > so that the user don't have to do it themselves. > > Signed-off-by: GIRARD Etienne > --- Thanks. As I do not really do "p4", I am CC'ing this response to the area experts. First, one "procedural" comment. You

[PATCH] git-p4: Handle p4 submit failure

Clean the workspace if p4_write_pipe raised SystemExit, so that the user don't have to do it themselves. Signed-off-by: GIRARD Etienne --- git-p4.py | 71 +-- 1 file changed, 37 insertions(+), 34 deletions(-) The p4 submit command may