Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Junio C Hamano
Pete Wyckoff writes: > You should send the patch to junio for inclusion in pu/ for the > next release, with: > > Acked-by: Pete Wyckoff Thanks; I'll queue this then. -- >8 -- From: Alexandru Juncu Date: Thu, 8 Aug 2013 16:17:38 +0300 Subject: [PATCH] git-p4: Fix occa

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Alexandru Juncu
On 12 August 2013 15:38, Pete Wyckoff wrote: > al...@rosedu.org wrote on Mon, 12 Aug 2013 10:46 +0300: >> On 11 August 2013 14:57, Pete Wyckoff wrote: >> > al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: >> >> Symlink contents in p4 print sometimes have a trailing >> >> new line character

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Pete Wyckoff
al...@rosedu.org wrote on Mon, 12 Aug 2013 10:46 +0300: > On 11 August 2013 14:57, Pete Wyckoff wrote: > > al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: > >> Symlink contents in p4 print sometimes have a trailing > >> new line character, but sometimes it doesn't. git-p4 > >> should only

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-12 Thread Alexandru Juncu
On 11 August 2013 14:57, Pete Wyckoff wrote: > al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: >> Symlink contents in p4 print sometimes have a trailing >> new line character, but sometimes it doesn't. git-p4 >> should only remove the last character if that character >> is '\n'. > > Your p

Re: [PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-11 Thread Pete Wyckoff
al...@rosedu.org wrote on Thu, 08 Aug 2013 16:17 +0300: > Symlink contents in p4 print sometimes have a trailing > new line character, but sometimes it doesn't. git-p4 > should only remove the last character if that character > is '\n'. Your patch looks fine, and harmless if symlinks continue to h

[PATCH] git-p4: Fix occasional truncation of symlink contents.

2013-08-08 Thread Alexandru Juncu
Symlink contents in p4 print sometimes have a trailing new line character, but sometimes it doesn't. git-p4 should only remove the last character if that character is '\n'. Signed-off-by: Alex Juncu Signed-off-by: Alex Badea --- git-p4.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletio