[PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-05-24 Thread Maxime Coste
The diff information render the spec file unusable as is by p4, do not include it when run with --prepare-p4-only so that the given file can be directly passed to p4. With --prepare-p4-only, git-p4 already tells the user it can use p4 submit with the generated spec file. This fails because of the

Re: [PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-05-24 Thread Pete Wyckoff
frrr...@gmail.com wrote on Sat, 24 May 2014 02:39 +0100: > The diff information render the spec file unusable as is by p4, > do not include it when run with --prepare-p4-only so that the > given file can be directly passed to p4. > > With --prepare-p4-only, git-p4 already tells the user it can use

Re: [PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-05-23 Thread Maxime Coste
Hello Sorry for the delay, I hope that version is more acceptable. I updated the test case as well, but did not manage to get the actual p4 tests to work here (I have p4 and p4d installed, they start but all the other tests seems to fail). Still the change is straightforward. Cheers, Maxime Cos

[PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-05-23 Thread Maxime Coste
The diff information render the spec file unusable as is by p4, do not include it when run with --prepare-p4-only so that the given file can be directly passed to p4. With --prepare-p4-only, git-p4 already tells the user it can use p4 submit with the generated spec file. This fails because of the

Re: [PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-01-13 Thread Pete Wyckoff
frrr...@gmail.com wrote on Mon, 13 Jan 2014 12:10 +: > Hello, > > On Sun, Jan 12, 2014 at 05:29:46PM -0500, Pete Wyckoff wrote: > > Thanks for the patch, but I'm curious how you'd like this to > > work. I never use the option myself. > > > > As it is, --prepare-p4-only generates a file in /t

Re: [PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-01-13 Thread Maxime Coste
Hello, On Sun, Jan 12, 2014 at 05:29:46PM -0500, Pete Wyckoff wrote: > Thanks for the patch, but I'm curious how you'd like this to > work. I never use the option myself. > > As it is, --prepare-p4-only generates a file in /tmp/ that has > exactly the contents you'd see in the editor during "git

Re: [PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-01-12 Thread Pete Wyckoff
frrr...@gmail.com wrote on Fri, 10 Jan 2014 18:18 +: > The diff information render the spec file unusable as is by p4, > do not include it when run with --prepare-p4-only so that the > given file can be directly passed to p4. Thanks for the patch, but I'm curious how you'd like this to work.

[PATCH] git-p4: Do not include diff in spec file when just preparing p4

2014-01-10 Thread Maxime Coste
The diff information render the spec file unusable as is by p4, do not include it when run with --prepare-p4-only so that the given file can be directly passed to p4. --- git-p4.py | 70 +++ 1 file changed, 39 insertions(+), 31 deletions(