Re: [PATCH] git-gui: Update in-memory config when changing config options

2019-08-26 Thread Pratyush Yadav
On 26/08/19 07:22AM, Junio C Hamano wrote: > Pratyush Yadav writes: > > > > Subject: Re: [PATCH] git-gui: Update in-memory config when changing config > > options > > s/git-gui: Update/git-gui: update/ I fixed this in my tree, just didn't send a re-roll w

Re: [PATCH] git-gui: Update in-memory config when changing config options

2019-08-26 Thread Junio C Hamano
Pratyush Yadav writes: > Subject: Re: [PATCH] git-gui: Update in-memory config when changing config > options s/git-gui: Update/git-gui: update/ > lib/option.tcl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/option.tcl b/lib/option.tcl > index e43971b..1

Re: [PATCH] git-gui: Update in-memory config when changing config options

2019-08-25 Thread Pratyush Yadav
Junio, This patch hasn't got any comments, but it looks correct to me, and fit for merging IMO. I updated the commit subject from 'git-gui: Update...' to 'git-gui: update...' to match with the style of other commit messages, as you suggested in the other series. You can pull the updated commi

[PATCH] git-gui: Update in-memory config when changing config options

2019-08-22 Thread Pratyush Yadav
When the user updates any config variable from the options menu, the new config gets saved, but the in-memory state of the config variables is not updated. This results in the old settings being used until the user either opens the options menu again (which triggers a call to load_config), or re-st