Re: [PATCH] git-gui: Do not reset author details on amend

2016-09-27 Thread Stefan Beller
On Tue, Sep 27, 2016 at 10:23 AM, Orgad Shaneh wrote: > On Tue, Sep 27, 2016 at 7:31 PM, Junio C Hamano wrote: >> Orgad Shaneh writes: >> >>> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote: Orgad Shaneh writes: >>> I actually see that there is a problem with it: >>> https://g

Re: [PATCH] git-gui: Do not reset author details on amend

2016-09-27 Thread Orgad Shaneh
On Tue, Sep 27, 2016 at 7:31 PM, Junio C Hamano wrote: > Orgad Shaneh writes: > >> On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote: >>> Orgad Shaneh writes: >>> >> I actually see that there is a problem with it: >> https://github.com/git-for-windows/git/issues/761 >> >> I'll try to revis

Re: [PATCH] git-gui: Do not reset author details on amend

2016-09-27 Thread Junio C Hamano
Orgad Shaneh writes: > On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote: >> Orgad Shaneh writes: >> > I actually see that there is a problem with it: > https://github.com/git-for-windows/git/issues/761 > > I'll try to revise it and resubmit. Are you by chance volunteering to be git-gui m

Re: [PATCH] git-gui: Do not reset author details on amend

2016-09-27 Thread Orgad Shaneh
On Tue, Sep 27, 2016 at 12:34 AM, Junio C Hamano wrote: > Orgad Shaneh writes: > >> On Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote: >> >>> On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote: ping? >>> It's been over 2 months. Can anyone please review and merge it? >>> >> 4.5 mon

Re: [PATCH] git-gui: Do not reset author details on amend

2016-09-26 Thread Junio C Hamano
Orgad Shaneh writes: > On Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote: > >> On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote: >>> ping? >>> >> It's been over 2 months. Can anyone please review and merge it? >> > 4.5 months and counting... :( >> >>> On Thu, May 5, 2016 at 8:22 PM, Junio

Re: [PATCH] git-gui: Do not reset author details on amend

2016-09-26 Thread Orgad Shaneh
4.5 months and counting... :( - Orgad On Sun, Jul 10, 2016 at 7:36 AM, Orgad Shaneh wrote: > It's been over 2 months. Can anyone please review and merge it? > > Thanks. > - Orgad > > On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote: >> ping? >> >> On Thu, May 5, 2016 at 8:22 PM, Junio C Hama

Re: [PATCH] git-gui: Do not reset author details on amend

2016-07-09 Thread Orgad Shaneh
It's been over 2 months. Can anyone please review and merge it? Thanks. - Orgad On Wed, May 18, 2016 at 9:12 AM, Orgad Shaneh wrote: > ping? > > On Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote: >> Pat, we haven't heard from you for a long time. Are you still >> around and interested in he

Re: [PATCH] git-gui: Do not reset author details on amend

2016-05-17 Thread Orgad Shaneh
ping? On Thu, May 5, 2016 at 8:22 PM, Junio C Hamano wrote: > Pat, we haven't heard from you for a long time. Are you still > around and interested in helping us by maintaining git-gui? > > Otherwise we may have to start recruiting a volunteer or two to take > this over. > > Thanks. > > Orgad Sh

Re: [PATCH] git-gui: Do not reset author details on amend

2016-05-05 Thread Junio C Hamano
Pat, we haven't heard from you for a long time. Are you still around and interested in helping us by maintaining git-gui? Otherwise we may have to start recruiting a volunteer or two to take this over. Thanks. Orgad Shaneh writes: > git commit --amend preserves the author details unless --res

[PATCH] git-gui: Do not reset author details on amend

2016-05-05 Thread Orgad Shaneh
git commit --amend preserves the author details unless --reset-author is given. git-gui discards the author details on amend. Fix by reading the author details along with the commit message, and setting the appropriate environment variables required for preserving them. Reported long ago in the