Re: [PATCH] git-credential-netrc: fix uninitialized warning

2013-10-08 Thread Ted Zlatanov
On Tue, 8 Oct 2013 13:02:35 -0700 Jonathan Nieder wrote: JN> Ted Zlatanov wrote: >> On Tue, 8 Oct 2013 12:41:47 -0700 Jonathan Nieder >> wrote: JN> Ted Zlatanov wrote: Simple patch to avoid unitialized warning and log what we'll do. JN> Sign-off? >> >> I didn't realize it was a require

Re: [PATCH] git-credential-netrc: fix uninitialized warning

2013-10-08 Thread Ted Zlatanov
On Tue, 08 Oct 2013 21:58:41 +0200 Stefan Beller wrote: SB> On 10/08/2013 09:55 PM, Ted Zlatanov wrote: JN> Sign-off? >> >> I didn't realize it was a requirement, must I? SB> Yes, this is a requirement. See Documentation/SubmittingPatches SB> to read what signing off actually means here. OK,

Re: [PATCH] git-credential-netrc: fix uninitialized warning

2013-10-08 Thread Jonathan Nieder
Ted Zlatanov wrote: > On Tue, 8 Oct 2013 12:41:47 -0700 Jonathan Nieder wrote: > JN> Ted Zlatanov wrote: >>> Simple patch to avoid unitialized warning and log what we'll do. > JN> Sign-off? > > I didn't realize it was a requirement, must I? See Documentation/SubmittingPatches, section '(5) Sign

Re: [PATCH] git-credential-netrc: fix uninitialized warning

2013-10-08 Thread Stefan Beller
On 10/08/2013 09:55 PM, Ted Zlatanov wrote: > JN> Sign-off? > > I didn't realize it was a requirement, must I? Yes, this is a requirement. See Documentation/SubmittingPatches to read what signing off actually means here. Stefan signature.asc Description: OpenPGP digital signature

Re: [PATCH] git-credential-netrc: fix uninitialized warning

2013-10-08 Thread Ted Zlatanov
On Tue, 8 Oct 2013 12:41:47 -0700 Jonathan Nieder wrote: JN> Ted Zlatanov wrote: >> Simple patch to avoid unitialized warning and log what we'll do. JN> Sign-off? I didn't realize it was a requirement, must I? JN> [...] >> --- a/contrib/credential/netrc/git-credential-netrc >> +++ b/contrib/

Re: [PATCH] git-credential-netrc: fix uninitialized warning

2013-10-08 Thread Jonathan Nieder
Hi, Ted Zlatanov wrote: > Simple patch to avoid unitialized warning and log what we'll do. Sign-off? [...] > --- a/contrib/credential/netrc/git-credential-netrc > +++ b/contrib/credential/netrc/git-credential-netrc > @@ -369,7 +369,10 @@ sub find_netrc_entry { > { > my $entr

[PATCH] git-credential-netrc: fix uninitialized warning

2013-10-08 Thread Ted Zlatanov
Simple patch to avoid unitialized warning and log what we'll do. --- contrib/credential/netrc/git-credential-netrc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/contrib/credential/netrc/git-credential-netrc b/contrib/credential/netrc/git-credential-netrc index 6c51c43..