Re: [PATCH] git-compat-util.h: move extension stripping from handle_builtin()

2016-02-20 Thread Alexander Kuleshov
Hello Jeff, On 02-20-16, Jeff King wrote: > On Sat, Feb 20, 2016 at 02:10:58PM +0600, Alexander Kuleshov wrote: > > I'm not convinced that moving the functions inline into git-compat-util > is actually cleaner. We've expanded the interface that is visible to the > whole code base, warts at all. >

Re: [PATCH] git-compat-util.h: move extension stripping from handle_builtin()

2016-02-20 Thread Jeff King
On Sat, Feb 20, 2016 at 02:10:58PM +0600, Alexander Kuleshov wrote: > The handle_builtin() starts from striping of command extension if > STRIP_EXTENSION is enabled. As this is an OS dependent, let's move > to the git-compat-util.h as all similar functions to do handle_builtin() > more cleaner. I

[PATCH] git-compat-util.h: move extension stripping from handle_builtin()

2016-02-20 Thread Alexander Kuleshov
The handle_builtin() starts from striping of command extension if STRIP_EXTENSION is enabled. As this is an OS dependent, let's move to the git-compat-util.h as all similar functions to do handle_builtin() more cleaner. --- git-compat-util.h | 18 ++ git.c | 13 +---