Re: [PATCH] git-commit: search author pattern against mailmap

2013-08-23 Thread Junio C Hamano
Antoine Pelisse writes: > On Fri, Aug 23, 2013 at 9:03 PM, Junio C Hamano wrote: >> OK, so how about labelling it as a bugfix, like this perhaps? We >> obviously need a test or two, though. > > OK, > I will resubmit tomorrow with some tests. Thanks. Also, after I sent out that "like this" pat

Re: [PATCH] git-commit: search author pattern against mailmap

2013-08-23 Thread Antoine Pelisse
On Fri, Aug 23, 2013 at 9:03 PM, Junio C Hamano wrote: > OK, so how about labelling it as a bugfix, like this perhaps? We > obviously need a test or two, though. OK, I will resubmit tomorrow with some tests. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a messa

Re: [PATCH] git-commit: search author pattern against mailmap

2013-08-23 Thread Junio C Hamano
Jeff King writes: >> But for that old and established "--author parameter that does not >> use the standard format guesses" feature to be useful, I agree that >> it should honor the mailmap. >> >> I wonder if it would hurt anybody if we made this unconditional, not >> even with "--no-mailmap" ov

Re: [PATCH] git-commit: search author pattern against mailmap

2013-08-23 Thread Jeff King
On Fri, Aug 23, 2013 at 10:44:03AM -0700, Junio C Hamano wrote: > My initial reaction was "Why should something as important as 'git > commit' should be playing a guessing-game?" ;-) and I am kind of > ashamed to have added 146ea068 (git commit --author=$name: look > $name up in existing commits,

Re: [PATCH] git-commit: search author pattern against mailmap

2013-08-23 Thread Junio C Hamano
Antoine Pelisse writes: > When committing for someone else, using the --author option, it can be > nice to use the mailmap file to find the correct name spelling and email > address. > > Currently, you would have to find the correct mapping in mailmap file > first, and then use the full ident for

[PATCH] git-commit: search author pattern against mailmap

2013-08-23 Thread Antoine Pelisse
When committing for someone else, using the --author option, it can be nice to use the mailmap file to find the correct name spelling and email address. Currently, you would have to find the correct mapping in mailmap file first, and then use the full ident form when committing. Let's allow git-c