Re: [PATCH] git-clean: remove fifo, devices, socket files

2016-07-16 Thread Andrew Vagin
On Fri, Jul 15, 2016 at 10:33:42PM +0200, Johannes Sixt wrote: > Am 15.07.2016 um 09:46 schrieb Andrey Vagin: > > On Thu, Jul 14, 2016 at 10:56 PM, Johannes Sixt wrote: > > > IOW: These special files are invisible for Git unless it already knows the > > > names. The latter case is outside 'git cle

Re: [PATCH] git-clean: remove fifo, devices, socket files

2016-07-15 Thread Johannes Sixt
Am 15.07.2016 um 09:46 schrieb Andrey Vagin: On Thu, Jul 14, 2016 at 10:56 PM, Johannes Sixt wrote: IOW: These special files are invisible for Git unless it already knows the names. The latter case is outside 'git clean's domain, and the former case really means that special files in the workin

Re: [PATCH] git-clean: remove fifo, devices, socket files

2016-07-15 Thread Johannes Schindelin
Hi Andrey, On Fri, 15 Jul 2016, Andrey Vagin wrote: > What will be wrong if 'git status' will reports these [fifo/socket] files? `git status` is intended to give you an idea what to commit next. And... > What will be wrong if 'git add' will returns an error instead of > skipping them silently?

Re: [PATCH] git-clean: remove fifo, devices, socket files

2016-07-15 Thread Andrey Vagin
On Thu, Jul 14, 2016 at 10:56 PM, Johannes Sixt wrote: > Am 15.07.2016 um 04:42 schrieb Andrey Vagin: >> >> Currently git-clean removes only links and files, but >> there can be special files like fifo, sockets, devices. >> >> I think git-clean has to remove them too. > > > I think that is not nec

Re: [PATCH] git-clean: remove fifo, devices, socket files

2016-07-14 Thread Johannes Sixt
Am 15.07.2016 um 04:42 schrieb Andrey Vagin: Currently git-clean removes only links and files, but there can be special files like fifo, sockets, devices. I think git-clean has to remove them too. I think that is not necessary. If you do mkfifo fifo && sudo mknod zero c 1 5 then 'git statu

[PATCH] git-clean: remove fifo, devices, socket files

2016-07-14 Thread Andrey Vagin
Currently git-clean removes only links and files, but there can be special files like fifo, sockets, devices. I think git-clean has to remove them too. Signed-off-by: Andrey Vagin --- cache.h | 8 dir.c | 4 2 files changed, 12 insertions(+) diff --git a/cache.h b/cache.h index