Re: [PATCH] git: submodule honor -c credential.* from command line

2016-02-24 Thread Junio C Hamano
Jacob Keller writes: Add a git submodule--helper function which can be used to sanitize the GIT_CONFIG_PARAMETERS value to only allow certain settings. For now, restrict this to only credential.* settings. >>> >>> I guess for now that subset is fine and will be expanded over time?

Re: [PATCH] git: submodule honor -c credential.* from command line

2016-02-24 Thread Jacob Keller
On Wed, Feb 24, 2016 at 3:36 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> On Wed, Feb 24, 2016 at 12:09 PM, Jacob Keller >> wrote: >>> From: Jacob Keller >>> >>> Due to the way that the git-submodule code works, it clears all local >>> git environment variables before entering submod

Re: [PATCH] git: submodule honor -c credential.* from command line

2016-02-24 Thread Jacob Keller
Hi, On Wed, Feb 24, 2016 at 3:27 PM, Stefan Beller wrote: > On Wed, Feb 24, 2016 at 12:09 PM, Jacob Keller > wrote: >> From: Jacob Keller >> Add a git submodule--helper function which can be used to sanitize the >> GIT_CONFIG_PARAMETERS value to only allow certain settings. For now, >> restric

Re: [PATCH] git: submodule honor -c credential.* from command line

2016-02-24 Thread Junio C Hamano
Stefan Beller writes: > On Wed, Feb 24, 2016 at 12:09 PM, Jacob Keller > wrote: >> From: Jacob Keller >> >> Due to the way that the git-submodule code works, it clears all local >> git environment variables before entering submodules. This is normally >> a good thing since we want to clear set

Re: [PATCH] git: submodule honor -c credential.* from command line

2016-02-24 Thread Stefan Beller
On Wed, Feb 24, 2016 at 12:09 PM, Jacob Keller wrote: > From: Jacob Keller > > Due to the way that the git-submodule code works, it clears all local > git environment variables before entering submodules. This is normally > a good thing since we want to clear settings such as GIT_WORKTREE and > o

[PATCH] git: submodule honor -c credential.* from command line

2016-02-24 Thread Jacob Keller
From: Jacob Keller Due to the way that the git-submodule code works, it clears all local git environment variables before entering submodules. This is normally a good thing since we want to clear settings such as GIT_WORKTREE and other variables which would affect the operation of submodule comma

[PATCH] git: submodule honor -c credential.* from command line

2016-02-24 Thread Jacob Keller
From: Jacob Keller Due to the way that the git-submodule code works, it clears all local git environment variables before entering submodules. This is normally a good thing since we want to clear settings such as GIT_WORKTREE and other variables which would affect the operation of submodule comma