Re: [PATCH] git: make was_alias and done_help non-static

2015-03-03 Thread Stefan Näwe
Am 02.03.2015 um 13:02 schrieb Alexander Kuleshov: > 'was_alias' variable does not need to store it's value on each > iteration in the loop, anyway this variable changes it's value with run_argv. s/it's/its/ > 'done_help' variable does not need to be static variable too if we'll move it > out th

Re: [PATCH] git: make was_alias and done_help non-static

2015-03-02 Thread Jeff King
On Mon, Mar 02, 2015 at 06:02:37PM +0600, Alexander Kuleshov wrote: > 'was_alias' variable does not need to store it's value on each > iteration in the loop, anyway this variable changes it's value with run_argv. > > 'done_help' variable does not need to be static variable too if we'll move it >

[PATCH] git: make was_alias and done_help non-static

2015-03-02 Thread Alexander Kuleshov
'was_alias' variable does not need to store it's value on each iteration in the loop, anyway this variable changes it's value with run_argv. 'done_help' variable does not need to be static variable too if we'll move it out the loop. So these variables do not need to be static. Signed-off-by: Ale