Junio C Hamano wrote:
> Eric Wong writes:
>
> >> Also, doesn't it break "git rebase" (non-interactive), or anything
> >> that internally runs format-patch to individual files and then runs
> >> am on each of them, anything that knows that each output file from
> >> format-patch corresponds to a
Eric Wong writes:
>> Also, doesn't it break "git rebase" (non-interactive), or anything
>> that internally runs format-patch to individual files and then runs
>> am on each of them, anything that knows that each output file from
>> format-patch corresponds to a single change and there is no need
Junio C Hamano wrote:
> Junio C Hamano writes:
> > Eric Wong writes:
> >
> >> Users have mistakenly copied "From " lines into commit messages
> >> in the past, and will certainly make the same mistakes in the
> >> future. Since not everyone uses mboxrd, yet, we should at least
> >> prevent miss
Junio C Hamano writes:
> Eric Wong writes:
>
>> Users have mistakenly copied "From " lines into commit messages
>> in the past, and will certainly make the same mistakes in the
>> future. Since not everyone uses mboxrd, yet, we should at least
>> prevent miss-split mails by always escaping "Fro
Junio C Hamano wrote:
> As a tool to produce mbox file, quoting like this in format-patch
> output may make sense, I would think, but shouldn't send-email undo
> this when sending individual patches?
Yes, that sounds like a good idea. Thanks.
Will followup in a day or two.
--
To unsubscribe from
Eric Wong writes:
> Users have mistakenly copied "From " lines into commit messages
> in the past, and will certainly make the same mistakes in the
> future. Since not everyone uses mboxrd, yet, we should at least
> prevent miss-split mails by always escaping "From " lines based
> on the check u
Johannes Schindelin wrote:
> I think that this change:
> deserves to live in a separate patch... It would make the real change
> stick out better.
Good point, I actually wrote a looser check based on
is_mboxrd_from before realizing the stricter check from
mailsplit would probably be more appro
Hi Eric,
I think that this change:
On Fri, 22 Jul 2016, Eric Wong wrote:
> diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c
> index 3068168..bb8f9c9 100644
> --- a/builtin/mailsplit.c
> +++ b/builtin/mailsplit.c
> @@ -8,41 +8,11 @@
> #include "builtin.h"
> #include "string-list.h"
> #in
Users have mistakenly copied "From " lines into commit messages
in the past, and will certainly make the same mistakes in the
future. Since not everyone uses mboxrd, yet, we should at least
prevent miss-split mails by always escaping "From " lines based
on the check used by mailsplit.
mailsplit w
9 matches
Mail list logo
