Re: [PATCH] for_each_reflog_ent_reverse: turn leftover check into assertion

2014-12-05 Thread Junio C Hamano
Jeff King writes: > I _think_ the patch below is also applicable to the code before my > boundary-fixing patch. But the rearranging also made me more confident > in it. Yeah, thanks for a fix. > -- >8 -- > Subject: for_each_reflog_ent_reverse: turn leftover check into assertion > > Our loop sho

[PATCH] for_each_reflog_ent_reverse: turn leftover check into assertion

2014-12-04 Thread Jeff King
On Thu, Dec 04, 2014 at 08:28:54PM -0500, Jeff King wrote: > The minimal fix here would be to add this special case to > the conditional that checks whether we found a newline. > But we can make the flow a little clearer by rearranging a > bit: we first handle lines that we are going to show, and