On Tue, May 16, 2017 at 2:46 AM, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
>> On Mon, 15 May 2017, Junio C Hamano wrote:
>>
>>> My knee-jerk reaction matched Dscho's, but grep is about contents,
>>> and we should be able to test this if we used a sensible tagnames or
>>> didn't use an
Johannes Schindelin writes:
> On Mon, 15 May 2017, Junio C Hamano wrote:
>
>> My knee-jerk reaction matched Dscho's, but grep is about contents,
>> and we should be able to test this if we used a sensible tagnames or
>> didn't use any. Glad to see somebody can step back and think ;-)
>
> Maybe s
Hi,
Johannes Schindelin wrote:
> On Fri, 12 May 2017, Jonathan Nieder wrote:
>> Would something like
>>
>> test PIPE_IN_FILENAME '
>> >"a|b" &&
>> test -f "a|b"
>> '
>>
>> work?
[...]
> Back to the subject: The MSYS2 emulation layer inherits a neat trick from
>
Hi Junio,
On Mon, 15 May 2017, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
> > Thanks for the hotfix. I'll fix this in my v2, but do it differently
> > in such a way that I can still run these tests on windows.
> >
> > I.e. the actual test here just needs these odd characters in t
Ævar Arnfjörð Bjarmason writes:
> Thanks for the hotfix. I'll fix this in my v2, but do it differently
> in such a way that I can still run these tests on windows.
>
> I.e. the actual test here just needs these odd characters in the
> commit message. It's just an unintended implementation detail
Hi Jonathan,
On Fri, 12 May 2017, Jonathan Nieder wrote:
> Johannes Schindelin wrote:
>
> > On Windows, `(1|2)` is not a valid file name, and therefore the tag
> > cannot be created as expected by the new test.
> >
> > So simply skip this test on Windows.
> >
> > Signed-off-by: Johannes Schindel
On Sat, May 13, 2017 at 1:44 AM, Jonathan Nieder wrote:
> Johannes Schindelin wrote:
>
>> On Windows, `(1|2)` is not a valid file name, and therefore the tag
>> cannot be created as expected by the new test.
>>
>> So simply skip this test on Windows.
>>
>> Signed-off-by: Johannes Schindelin
>> --
On Fri, May 12, 2017 at 12:50 PM, Johannes Schindelin
wrote:
> On Windows, `(1|2)` is not a valid file name, and therefore the tag
> cannot be created as expected by the new test.
>
> So simply skip this test on Windows.
Thanks for the hotfix. I'll fix this in my v2, but do it differently
in such
Johannes Schindelin wrote:
> On Windows, `(1|2)` is not a valid file name, and therefore the tag
> cannot be created as expected by the new test.
>
> So simply skip this test on Windows.
>
> Signed-off-by: Johannes Schindelin
> ---
Reviewed-by: Jonathan Nieder
I wouldn't be surprised if there
Johannes Schindelin writes:
> On Windows, `(1|2)` is not a valid file name, and therefore the tag
> cannot be created as expected by the new test.
>
> So simply skip this test on Windows.
>
> Signed-off-by: Johannes Schindelin
> ---
Will queue as an emergency fix on 'pu' for now, but I'd expect
On Windows, `(1|2)` is not a valid file name, and therefore the tag
cannot be created as expected by the new test.
So simply skip this test on Windows.
Signed-off-by: Johannes Schindelin
---
Published-As:
https://github.com/dscho/git/releases/tag/exhaustive-grep-tests-fixup-v1
Fetch-It-Via: git
11 matches
Mail list logo
