Re: [PATCH] fetch-pack: fix object_id of exact sha1

2016-02-29 Thread Jeff King
On Sun, Feb 28, 2016 at 11:29:39AM -0800, Junio C Hamano wrote: > Gabriel Souza Franco writes: > > >>> struct object_id oid; > >>> > >>> - if (!get_oid_hex(name, &oid) && name[GIT_SHA1_HEXSZ] == ' ') > >>> - name += GIT_SHA1_HEXSZ + 1; > >>> - else > >>> + if (get_o

Re: [PATCH] fetch-pack: fix object_id of exact sha1

2016-02-28 Thread Junio C Hamano
Gabriel Souza Franco writes: >>> struct object_id oid; >>> >>> - if (!get_oid_hex(name, &oid) && name[GIT_SHA1_HEXSZ] == ' ') >>> - name += GIT_SHA1_HEXSZ + 1; >>> - else >>> + if (get_oid_hex(name, &oid)) >>> oidclr(&oid); >>> + else if (name[GIT_S

Re: [PATCH] fetch-pack: fix object_id of exact sha1

2016-02-27 Thread Gabriel Souza Franco
On Sat, Feb 27, 2016 at 7:12 PM, Jeff King wrote: > On Sat, Feb 27, 2016 at 05:32:54PM -0300, Gabriel Souza Franco wrote: > >> Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, >> 2013-12-05) added support for specifying a SHA-1 as well as a ref name. >> Add support for specifying

Re: [PATCH] fetch-pack: fix object_id of exact sha1

2016-02-27 Thread Jeff King
On Sat, Feb 27, 2016 at 05:32:54PM -0300, Gabriel Souza Franco wrote: > Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, > 2013-12-05) added support for specifying a SHA-1 as well as a ref name. > Add support for specifying just a SHA-1 and set the ref name to the same > value in

[PATCH] fetch-pack: fix object_id of exact sha1

2016-02-27 Thread Gabriel Souza Franco
Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well, 2013-12-05) added support for specifying a SHA-1 as well as a ref name. Add support for specifying just a SHA-1 and set the ref name to the same value in this case. Signed-off-by: Gabriel Souza Franco --- builtin/fetch-pack.c | 6