Re: [PATCH] fast-import: Do less work when given "from" matches current branch head

Junio C Hamano writes: > Mike Hommey writes: > >>> Does that mean the original code was doing a release that was >>> unnecessary? Or does it mean this patch changes what happens on >>> that codepath, namely (1) leaking resource, and/or (2) keeping a >>> tree of the original 'b' that does not ha

Re: [PATCH] fast-import: Do less work when given "from" matches current branch head

Mike Hommey writes: >> Does that mean the original code was doing a release that was >> unnecessary? Or does it mean this patch changes what happens on >> that codepath, namely (1) leaking resource, and/or (2) keeping a >> tree of the original 'b' that does not have anything to do with the >> tr

Re: [PATCH] fast-import: Do less work when given "from" matches current branch head

On Thu, Jul 09, 2015 at 01:37:02PM -0700, Junio C Hamano wrote: > Mike Hommey writes: > > Cc'ed a few people who appear at the top of "shortlog --no-merges"; > I think the end result is not incorrect, but I want to hear second > opinions on this one. I do not know Shawn still remembers this > co

Re: [PATCH] fast-import: Do less work when given "from" matches current branch head

Mike Hommey writes: Cc'ed a few people who appear at the top of "shortlog --no-merges"; I think the end result is not incorrect, but I want to hear second opinions on this one. I do not know Shawn still remembers this code, but what is under discussion seems to have come mostly from ea5e370a (fa

[PATCH] fast-import: Do less work when given "from" matches current branch head

When building a fast-import stream, it's easy to forget the fact that for non-merge commits happening on top of the current branch head, there is no need for a "from" command. That is corroborated by the fact that at least git-p4, hg-fast-export and felipec's git-remote-hg all unconditionally use a