Re: [PATCH] do not use GIT_TRACE_PACKET=3 in tests

2013-03-21 Thread Junio C Hamano
Johannes Sixt writes: > Am 3/20/2013 18:43, schrieb Jeff King: >> Now that we are using the GIT_TRACE mechanism, we can >> improve both scripts by asking git to write directly to a >> file rather than a descriptor. That fixes the hang in t5700, >> and should allow t5503 to successfully run on Win

Re: [PATCH] do not use GIT_TRACE_PACKET=3 in tests

2013-03-20 Thread Johannes Sixt
Am 3/20/2013 18:43, schrieb Jeff King: > Now that we are using the GIT_TRACE mechanism, we can > improve both scripts by asking git to write directly to a > file rather than a descriptor. That fixes the hang in t5700, > and should allow t5503 to successfully run on Windows. Well spotted, and, righ

Re: [PATCH] do not use GIT_TRACE_PACKET=3 in tests

2013-03-20 Thread Jeff King
On Wed, Mar 20, 2013 at 04:29:40PM -0400, Eric Sunshine wrote: > On Wed, Mar 20, 2013 at 1:43 PM, Jeff King wrote: > > Some test scripts use the GIT_TRACE mechanism to dump > > debugging information to descriptor 3 (and point it to a > > file using the shell). On Windows, however, bash is unable

Re: [PATCH] do not use GIT_TRACE_PACKET=3 in tests

2013-03-20 Thread Eric Sunshine
On Wed, Mar 20, 2013 at 1:43 PM, Jeff King wrote: > Some test scripts use the GIT_TRACE mechanism to dump > debugging information to descriptor 3 (and point it to a > file using the shell). On Windows, however, bash is unable > to set up descriptor 3. We do not write our trace to the > file, and w

[PATCH] do not use GIT_TRACE_PACKET=3 in tests

2013-03-20 Thread Jeff King
Some test scripts use the GIT_TRACE mechanism to dump debugging information to descriptor 3 (and point it to a file using the shell). On Windows, however, bash is unable to set up descriptor 3. We do not write our trace to the file, and worse, we may interfere with other operations happening on des