[PATCH] difftool: silence warning

2012-08-21 Thread Ross Lagerwall
Silence a warning given when running git difftool --dir-diff and there are no changes. This is because command_oneline returns undef when the command has no output, not ''. Signed-off-by: Ross Lagerwall --- git-difftool.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git

Re: [PATCH] difftool: silence warning

2012-08-21 Thread Ross Lagerwall
On 08/21/2012 11:04 AM, David Aguilar wrote: > This patch is obviously correct, but it won't apply in git's "next" branch. > Can you please prepare a patch based on the version in next? > Sure. > > A small question on Perl style for the list... is it better say this? > >exit(0) unless $diff

Re: [PATCH] difftool: silence warning

2012-08-21 Thread David Aguilar
On Mon, Aug 20, 2012 at 11:59 PM, Ross Lagerwall wrote: > Silence a warning given when running git difftool --dir-diff and > there are no changes. > This is because command_oneline returns undef when the command has no > output, not ''. > > Signed-off-by: Ross Lagerwall Thanks This patch is obv

[PATCH] difftool: silence warning

2012-08-20 Thread Ross Lagerwall
Silence a warning given when running git difftool --dir-diff and there are no changes. This is because command_oneline returns undef when the command has no output, not ''. Signed-off-by: Ross Lagerwall --- git-difftool.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git