Re: [PATCH] diff --no-index: allow pathspec after --

2014-09-21 Thread Duy Nguyen
On Sun, Sep 21, 2014 at 1:19 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Coming back to the command line syntax for the new feature, if I had >> to choose, I would say >> >> git diff --no-index [-] [--] >> >> perhaps? As we never compare anything other than two things,... >

Re: [PATCH] diff --no-index: allow pathspec after --

2014-09-20 Thread Junio C Hamano
Junio C Hamano writes: > Coming back to the command line syntax for the new feature, if I had > to choose, I would say > > git diff --no-index [-] [--] > > perhaps? As we never compare anything other than two things,... Actually, I am not so sure about this anymore. It is not entirely

Re: [PATCH] diff --no-index: allow pathspec after --

2014-09-20 Thread Duy Nguyen
On Fri, Sep 19, 2014 at 5:41 AM, Junio C Hamano wrote: >> @@ -194,19 +207,23 @@ void diff_no_index(struct rev_info *revs, >> int j; >> if (!strcmp(argv[i], "--no-index")) >> i++; >> - else if (!strcmp(argv[i], "--")) >> + el

Re: [PATCH] diff --no-index: allow pathspec after --

2014-09-18 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Another patch to test the water before I put more effort into it. > > Commit d516c2d (Teach git-diff-files the new option `--no-index` - > 2007-02-22) brings the bells and whistles of git-diff to the world > outside a git repository. This patch continues that direc

[PATCH] diff --no-index: allow pathspec after --

2014-09-09 Thread Nguyễn Thái Ngọc Duy
Another patch to test the water before I put more effort into it. Commit d516c2d (Teach git-diff-files the new option `--no-index` - 2007-02-22) brings the bells and whistles of git-diff to the world outside a git repository. This patch continues that direction and adds a new syntax git diff