Re: [PATCH] credential: add nocache option to the credentials API

2019-09-15 Thread Masaya Suzuki
On Mon, Aug 26, 2019 at 9:28 AM Junio C Hamano wrote: > > Jeff King writes: > > > I was thinking that Git itself could treat "ttl=0" specially, the same > > as your nocache, and avoid passing it along to any helpers during the > > approve stage. That would make it exactly equivalent to your patch

Re: [PATCH] credential: add nocache option to the credentials API

2019-08-26 Thread Junio C Hamano
Jeff King writes: > I was thinking that Git itself could treat "ttl=0" specially, the same > as your nocache, and avoid passing it along to any helpers during the > approve stage. That would make it exactly equivalent to your patch > (modulo the name change). > ... > And as you noted above, if we

Re: [PATCH] credential: add nocache option to the credentials API

2019-07-22 Thread Jeff King
On Mon, Jul 22, 2019 at 10:30:52AM -0700, Masaya Suzuki wrote: > > In that patch, I essentially proposed making all gathered credentials as > > nocache. That's a more secure default (though in some cases less > > convenient). > > > > It did break a case Shawn had of caching the result of another h

Re: [PATCH] credential: add nocache option to the credentials API

2019-07-22 Thread Masaya Suzuki
On Tue, Jul 9, 2019 at 5:56 AM Jeff King wrote: > > On Sat, Jul 06, 2019 at 10:51:32PM -0700, Masaya Suzuki wrote: > > > The credentials API calls credentials helpers in order. If a > > username/password pair is returned the helpers and if it's used for > > authentication successfully, it's announ

Re: [PATCH] credential: add nocache option to the credentials API

2019-07-09 Thread Jeff King
On Sat, Jul 06, 2019 at 10:51:32PM -0700, Masaya Suzuki wrote: > The credentials API calls credentials helpers in order. If a > username/password pair is returned the helpers and if it's used for > authentication successfully, it's announced to the helpers and they can > store it for later use. >

[PATCH] credential: add nocache option to the credentials API

2019-07-06 Thread Masaya Suzuki
The credentials API calls credentials helpers in order. If a username/password pair is returned the helpers and if it's used for authentication successfully, it's announced to the helpers and they can store it for later use. Some credentials are valid only for the limited time and should not be ca