Re: [PATCH] contrib/subtree: ensure only one rev is provided

atch below for your convenience. Thanks, Denton -- >8 -- Subject: [PATCH] contrib/subtree: ensure only one rev is provided While looking at the inline help for git-subtree.sh, I noticed that git subtree split --prefix= was given as an option. However, it only really makes sense to pro

Re: [PATCH] contrib/subtree: ensure only one rev is provided

On Thu, Feb 07, 2019 at 05:34:38PM -0500, Avery Pennarun wrote: > But I don't see any major problems with the patch in this thread. > > Thanks! > > Avery Hi Junio, If there are no other comments, I think that this patch is ready to be queued. Thanks, Denton

Re: [PATCH] contrib/subtree: ensure only one rev is provided

]0;joe - On Thu, Feb 7, 2019 at 1:54 PM Junio C Hamano wrote: > I am not sure if the other caller is OK, though. cmd_add_repository > can get more than one revs, and uses the first one as $rev to read > the tree from, expecting that this helper to ignore other ones that > are emitted from 'git r

Re: [PATCH] contrib/subtree: ensure only one rev is provided

Denton Liu writes: > @@ -185,6 +191,7 @@ if test "$command" != "pull" && > then > revs=$(git rev-parse $default --revs-only "$@") || exit $? > dirs=$(git rev-parse --no-revs --no-flags "$@") || exit $? > + ensure_single_rev $revs This applies to anything other than pull, add and

[PATCH] contrib/subtree: ensure only one rev is provided

While looking at the inline help for git-subtree.sh, I noticed that git subtree split --prefix= was given as an option. However, it only really makes sense to provide one revision because of the way the commits are forwarded to rev-parse so this commit changes "" to "" to reflect this. I