Re: [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-21 Thread Johannes Schindelin
Hi Eric, On Wed, 20 Jul 2016, Eric Wong wrote: > Johannes Schindelin wrote: > > > > On Wed, 20 Jul 2016, Eric Wong wrote: > > > > > diff --git a/config.mak.uname b/config.mak.uname > > > index a88f139..6c29545 100644 > > > --- a/config.mak.uname > > > +++ b/config.mak.uname > > > @@ -202,6 +20

Re: [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-20 Thread brian m. carlson
On Wed, Jul 20, 2016 at 11:10:40AM -0700, Junio C Hamano wrote: > On Wed, Jul 20, 2016 at 11:07 AM, Eric Wong wrote: > > Also, my use of a numeric comparison may be more future-proof > > in case FreeBSD decides to have /usr/bin/perl again. > > > > I also wonder why we don't use `which` to search f

Re: [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-20 Thread Junio C Hamano
On Wed, Jul 20, 2016 at 11:07 AM, Eric Wong wrote: > Also, my use of a numeric comparison may be more future-proof > in case FreeBSD decides to have /usr/bin/perl again. > > I also wonder why we don't use `which` to search for somewhat > standard path components, instead. Something like: Because

Re: [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-20 Thread Eric Wong
Johannes Schindelin wrote: > Hi Eric, > > On Wed, 20 Jul 2016, Eric Wong wrote: > > > diff --git a/config.mak.uname b/config.mak.uname > > index a88f139..6c29545 100644 > > --- a/config.mak.uname > > +++ b/config.mak.uname > > @@ -202,6 +202,11 @@ ifeq ($(uname_S),FreeBSD) > > NO_UIN

Re: [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-20 Thread Johannes Schindelin
Hi Eric, On Wed, 20 Jul 2016, Eric Wong wrote: > diff --git a/config.mak.uname b/config.mak.uname > index a88f139..6c29545 100644 > --- a/config.mak.uname > +++ b/config.mak.uname > @@ -202,6 +202,11 @@ ifeq ($(uname_S),FreeBSD) > NO_UINTMAX_T = YesPlease > NO_STRTOUMA

[PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-19 Thread Eric Wong
Perl has not been part of the base system since FreeBSD 5.0: https://www.freebsd.org/releases/5.0R/relnotes-i386.html Signed-off-by: Eric Wong --- Does anybody still run git on FreeBSD 4.x or earlier? 4.11 was released a few months before git in 2005: https://www.freebsd.org