Re: [PATCH] config: restructure format_config() for better control flow

2015-08-20 Thread Junio C Hamano
Jeff King writes: > On Thu, Aug 20, 2015 at 04:14:22PM +0200, SZEDER Gábor wrote: > >> Commit 578625fa91 (config: add '--name-only' option to list only >> variable names, 2015-08-10) modified format_config() such that it >> returned from the middle of the function when showing only keys, >> resul

Re: [PATCH] config: restructure format_config() for better control flow

2015-08-20 Thread Jeff King
On Thu, Aug 20, 2015 at 04:14:22PM +0200, SZEDER Gábor wrote: > Commit 578625fa91 (config: add '--name-only' option to list only > variable names, 2015-08-10) modified format_config() such that it > returned from the middle of the function when showing only keys, > resulting in ugly code structure

[PATCH] config: restructure format_config() for better control flow

2015-08-20 Thread SZEDER Gábor
Commit 578625fa91 (config: add '--name-only' option to list only variable names, 2015-08-10) modified format_config() such that it returned from the middle of the function when showing only keys, resulting in ugly code structure. Reorganize the if statements and dealing with the key-value delimite