Re: [PATCH] config: reject invalid VAR in 'git -c VAR=VAL command'

2017-02-21 Thread Junio C Hamano
Stefan Beller writes: > Combining this thought with another email[1] that flew by, > do we also need to have this treatment for "git clone -c" You tell me ;-) Do we share the same parser? If not, should we make them share the same code? >> +for VAR in a .a a. a.0b a."b c". a."b c".0d >> +do

Re: [PATCH] config: reject invalid VAR in 'git -c VAR=VAL command'

2017-02-21 Thread Stefan Beller
On Tue, Feb 21, 2017 at 10:53 AM, Junio C Hamano wrote: > The parsing of one-shot assignments of configuration variables that > come from the command line historically was quite loose and allowed > anything to pass. > > The configuration variable names that come from files are validated > in git_c

[PATCH] config: reject invalid VAR in 'git -c VAR=VAL command'

2017-02-21 Thread Junio C Hamano
The parsing of one-shot assignments of configuration variables that come from the command line historically was quite loose and allowed anything to pass. The configuration variable names that come from files are validated in git_config_parse_source(), which uses get_base_var() that grabs the (and