Re: [PATCH] completion: add missing completions for log, diff, show

Hi Max, [your reply did not make it to the Git mailing list because it drops anything with an HTML part] On Thu, 12 Sep 2019, Max Rothman wrote: > Great! What’s the path for getting this merged? Usually it will be picked up into the `pu` branch first, then advance to `next`, and then to `master

Re: [PATCH] completion: add missing completions for log, diff, show

Johannes Schindelin writes: > Hi Max, > > The patch looks good to me! Thanks, both. Will queue.

Re: [PATCH] completion: add missing completions for log, diff, show

Hi Max, The patch looks good to me! Thanks, Johannes On Wed, 11 Sep 2019, Max Rothman wrote: > On Thu, Aug 1, 2019 at 8:54 PM Max Rothman wrote: > > > > On Thu, Aug 1, 2019 at 8:50 PM Max Rothman wrote: > > > > > > The bash completion script knows some options to "git log" and > > > "git show

Re: [PATCH] completion: add missing completions for log, diff, show

Just pinging again, I'd love to move this forward! On Thu, Aug 1, 2019 at 8:54 PM Max Rothman wrote: > > Ping :) > > > On Thu, Aug 1, 2019 at 8:50 PM Max Rothman wrote: > > > > The bash completion script knows some options to "git log" and > > "git show" only in the positive form, (e.g. "--abbr

Re: [PATCH] completion: add missing completions for log, diff, show

Ping :) On Thu, Aug 1, 2019 at 8:50 PM Max Rothman wrote: > > The bash completion script knows some options to "git log" and > "git show" only in the positive form, (e.g. "--abbrev-commit"), but not > in their negative form (e.g. "--no-abbrev-commit"). Add them. > > Also, the bash completion scr

[PATCH] completion: add missing completions for log, diff, show

The bash completion script knows some options to "git log" and "git show" only in the positive form, (e.g. "--abbrev-commit"), but not in their negative form (e.g. "--no-abbrev-commit"). Add them. Also, the bash completion script is missing some other options to "git diff", and "git show" (and thu

Re: [PATCH] completion: add missing completions for log, diff, show

Max Rothman writes: > How about this: > > The bash completion script knows some options to "git log" and > "git show" only in the positive form, (e.g. "--abbrev-commit"), but not > in their negative form (e.g. "--no-abbrev-commit"). Adds them. s/Adds them/Add them/; we speak as if we are giving

Re: [PATCH] completion: add missing completions for log, diff, show

>> Teach git-log tab completion about the --no-* options for ease of use >> at the command line. >> >> Similarly, teach git-show tab completion about the --no-abbrev-commit, >> --expand-tabs, and --no-expand-tabs options. >> >> Also, teach git-diff (and all commands that use its options) tab >> com

Re: [PATCH] completion: add missing completions for log, diff, show

Max Rothman writes: > From: Max Rothman Thanks. > > Teach git-log tab completion about the --no-* options for ease of use > at the command line. > > Similarly, teach git-show tab completion about the --no-abbrev-commit, > --expand-tabs, and --no-expand-tabs options. > > Also, teach git-diff (a

[PATCH] completion: add missing completions for log, diff, show

From: Max Rothman Teach git-log tab completion about the --no-* options for ease of use at the command line. Similarly, teach git-show tab completion about the --no-abbrev-commit, --expand-tabs, and --no-expand-tabs options. Also, teach git-diff (and all commands that use its options) tab compl