Re: [PATCH] commit-graph write: use pack order when finding commits

On 1/17/2019 10:09 AM, Derrick Stolee wrote: The code itself looks good, I just need to double-check the performance numbers. I tested this patch on our VFS-specific version using five "prefetch packs". Before: 22.61 s (avg) After: 22.18 s (avg) Improvement: 2% The error rate among the s

Re: [PATCH] commit-graph write: use pack order when finding commits

On 1/17/2019 8:23 AM, Ævar Arnfjörð Bjarmason wrote: Slightly optimize the "commit-graph write" step by using FOR_EACH_OBJECT_PACK_ORDER with for_each_object_in_pack(). See commit [1] and [2] for the facility and a similar optimization for "cat-file". On Linux it is around 5% slower to run:

[PATCH] commit-graph write: use pack order when finding commits

Slightly optimize the "commit-graph write" step by using FOR_EACH_OBJECT_PACK_ORDER with for_each_object_in_pack(). See commit [1] and [2] for the facility and a similar optimization for "cat-file". On Linux it is around 5% slower to run: echo 1 >/proc/sys/vm/drop_caches && cat .git/objec