Re: [PATCH] commit: make --only --allow-empty work without paths

2016-12-06 Thread Andreas Krey
On Mon, 05 Dec 2016 12:36:19 +, Junio C Hamano wrote: > Jeff King writes: > > On Sat, Dec 03, 2016 at 07:59:49AM +0100, Andreas Krey wrote: ... > >> Tool: git commit --allow-empty -m 'FIX: A-123' > > > > OK. I think "tool" is slightly funny here, but I get that is part of the > > real world wo

Re: [PATCH] commit: make --only --allow-empty work without paths

2016-12-05 Thread Junio C Hamano
Jeff King writes: > On Fri, Dec 02, 2016 at 11:15:13PM +0100, Andreas Krey wrote: > >> --only is implied when paths are present, and required >> them unless --amend. But with --allow-empty it should >> be allowed as well - it is the only way to create an >> empty commit in the presence of staged

Re: [PATCH] commit: make --only --allow-empty work without paths

2016-12-05 Thread Junio C Hamano
Jeff King writes: > On Sat, Dec 03, 2016 at 07:59:49AM +0100, Andreas Krey wrote: > >> > OK. I'm not sure why you would want to create an empty commit in such a >> > case. >> >> User: Ok tool, make me a pullreq. >> >> Tool: But you haven't mentioned any issue >> in your commit messages. W

Re: [PATCH] commit: make --only --allow-empty work without paths

2016-12-03 Thread Jeff King
On Sat, Dec 03, 2016 at 07:59:49AM +0100, Andreas Krey wrote: > > OK. I'm not sure why you would want to create an empty commit in such a > > case. > > User: Ok tool, make me a pullreq. > > Tool: But you haven't mentioned any issue > in your commit messages. Which are they? > > User: Ok,

Re: [PATCH] commit: make --only --allow-empty work without paths

2016-12-02 Thread Andreas Krey
On Fri, 02 Dec 2016 23:32:55 +, Jeff King wrote: > On Fri, Dec 02, 2016 at 11:15:13PM +0100, Andreas Krey wrote: > > > --only is implied when paths are present, and required > > them unless --amend. But with --allow-empty it should > > be allowed as well - it is the only way to create an > > e

Re: [PATCH] commit: make --only --allow-empty work without paths

2016-12-02 Thread Jeff King
On Fri, Dec 02, 2016 at 11:15:13PM +0100, Andreas Krey wrote: > --only is implied when paths are present, and required > them unless --amend. But with --allow-empty it should > be allowed as well - it is the only way to create an > empty commit in the presence of staged changes. OK. I'm not sure

[PATCH] commit: make --only --allow-empty work without paths

2016-12-02 Thread Andreas Krey
--only is implied when paths are present, and required them unless --amend. But with --allow-empty it should be allowed as well - it is the only way to create an empty commit in the presence of staged changes. Signed-off-by: Andreas Krey --- I stumbled over this omission trying to create an empt