Re: [PATCH] coccicheck: process every source file at once

2018-10-03 Thread Stefan Beller
On Wed, Oct 3, 2018 at 8:52 AM Jacob Keller wrote: > > On Wed, Oct 3, 2018 at 8:05 AM SZEDER Gábor wrote: > > In fact, it works finer than ever, because running 1.0.0 with this > > patch on Travis CI notices a possible memmove() -> MOVE_ARRAY() > > conversion: > > > > https://travis-ci.org/szed

Re: [PATCH] coccicheck: process every source file at once

2018-10-03 Thread Jacob Keller
On Wed, Oct 3, 2018 at 8:05 AM SZEDER Gábor wrote: > In fact, it works finer than ever, because running 1.0.0 with this > patch on Travis CI notices a possible memmove() -> MOVE_ARRAY() > conversion: > > https://travis-ci.org/szeder/git/jobs/436542684#L576 > > Surprisingly, running 1.0.0 without

Re: [PATCH] coccicheck: process every source file at once

2018-10-03 Thread Jacob Keller
On Wed, Oct 3, 2018 at 3:17 AM SZEDER Gábor wrote: > > On Tue, Oct 02, 2018 at 03:55:19PM -0400, Jeff King wrote: > > On Tue, Oct 02, 2018 at 12:16:42PM -0700, Jacob Keller wrote: > > > > > make coccicheck is used in order to apply coccinelle semantic patches, > > > and see if any of the transform

Re: [PATCH] coccicheck: process every source file at once

2018-10-03 Thread SZEDER Gábor
On Wed, Oct 03, 2018 at 12:16:58PM +0200, SZEDER Gábor wrote: > On Tue, Oct 02, 2018 at 03:55:19PM -0400, Jeff King wrote: > > On Tue, Oct 02, 2018 at 12:16:42PM -0700, Jacob Keller wrote: > > > > > make coccicheck is used in order to apply coccinelle semantic patches, > > > and see if any of the

Re: [PATCH] coccicheck: process every source file at once

2018-10-03 Thread SZEDER Gábor
On Tue, Oct 02, 2018 at 03:55:19PM -0400, Jeff King wrote: > On Tue, Oct 02, 2018 at 12:16:42PM -0700, Jacob Keller wrote: > > > make coccicheck is used in order to apply coccinelle semantic patches, > > and see if any of the transformations found within contrib/coccinelle/ > > can be applied to t

Re: [PATCH] coccicheck: process every source file at once

2018-10-02 Thread Jeff King
On Tue, Oct 02, 2018 at 01:58:10PM -0700, Jacob Keller wrote: > On Tue, Oct 2, 2018 at 1:31 PM Jeff King wrote: > > Actually, I guess we do not need to save $? at all, since we have only a > > single process to care about. So even simpler: > > > > spatch ... 2>$@+ 2>$@.log || > > { > >

Re: [PATCH] coccicheck: process every source file at once

2018-10-02 Thread Jacob Keller
On Tue, Oct 2, 2018 at 1:31 PM Jeff King wrote: > Actually, I guess we do not need to save $? at all, since we have only a > single process to care about. So even simpler: > > spatch ... 2>$@+ 2>$@.log || > { > cat $@.log > exit 1 > } > # if we get here, we were successful

Re: [PATCH] coccicheck: process every source file at once

2018-10-02 Thread Jeff King
On Tue, Oct 02, 2018 at 01:00:21PM -0700, Jacob Keller wrote: > > > This is nearly a 4x decrease in the time required to run make > > > coccicheck. This is due to the overhead of restarting spatch for every > > > file. By processing all files at once, we can amortize this startup cost > > > across

Re: [PATCH] coccicheck: process every source file at once

2018-10-02 Thread Jacob Keller
On Tue, Oct 2, 2018 at 12:55 PM Jeff King wrote: > > On Tue, Oct 02, 2018 at 12:16:42PM -0700, Jacob Keller wrote: > > > make coccicheck is used in order to apply coccinelle semantic patches, > > and see if any of the transformations found within contrib/coccinelle/ > > can be applied to the curre

Re: [PATCH] coccicheck: process every source file at once

2018-10-02 Thread Jeff King
On Tue, Oct 02, 2018 at 12:16:42PM -0700, Jacob Keller wrote: > make coccicheck is used in order to apply coccinelle semantic patches, > and see if any of the transformations found within contrib/coccinelle/ > can be applied to the current code base. > > Pass every file to a single invocation of

[PATCH] coccicheck: process every source file at once

2018-10-02 Thread Jacob Keller
From: Jacob Keller make coccicheck is used in order to apply coccinelle semantic patches, and see if any of the transformations found within contrib/coccinelle/ can be applied to the current code base. Pass every file to a single invocation of spatch, instead of running spatch once per source fi