Re: [PATCH] clone: support 'clone --shared' from a worktree

2017-12-11 Thread Brandon Williams
On 12/11, Eric Sunshine wrote: > On Mon, Dec 11, 2017 at 7:18 PM, Brandon Williams wrote: > > On 12/11, Eric Sunshine wrote: > >> struct strbuf alt = STRBUF_INIT; > >> - strbuf_addf(&alt, "%s/objects", src_repo); > >> + get_common_dir(&alt, src_repo); > >> +

Re: [PATCH] clone: support 'clone --shared' from a worktree

2017-12-11 Thread Eric Sunshine
On Mon, Dec 11, 2017 at 7:18 PM, Brandon Williams wrote: > On 12/11, Eric Sunshine wrote: >> struct strbuf alt = STRBUF_INIT; >> - strbuf_addf(&alt, "%s/objects", src_repo); >> + get_common_dir(&alt, src_repo); >> + strbuf_addstr(&alt, "/objects");

Re: [PATCH] clone: support 'clone --shared' from a worktree

2017-12-11 Thread Brandon Williams
On 12/11, Eric Sunshine wrote: > When worktree functionality was originally implemented, the possibility > of 'clone --local' from within a worktree was overlooked, with the > result that the location of the "objects" directory of the source > repository was computed incorrectly, thus the objects c

Re: [PATCH] clone: support 'clone --shared' from a worktree

2017-12-11 Thread Junio C Hamano
Eric Sunshine writes: > When worktree functionality was originally implemented, the possibility > of 'clone --local' from within a worktree was overlooked, with the > result that the location of the "objects" directory of the source > repository was computed incorrectly, thus the objects could no

[PATCH] clone: support 'clone --shared' from a worktree

2017-12-11 Thread Eric Sunshine
When worktree functionality was originally implemented, the possibility of 'clone --local' from within a worktree was overlooked, with the result that the location of the "objects" directory of the source repository was computed incorrectly, thus the objects could not be copied or hard-linked by th