Re: [PATCH] clarify documentation for remote helpers

2019-08-30 Thread Junio C Hamano
David Turner writes: > The only other restriction I see is: in order for the connectivity-skipping > optimization to be used, the file with s/.keep/.idx/, and the corresponding > pack, must exist. Do you think that's worth mentioning? It seems to be > implied by the rest of the text. Perhaps

RE: [PATCH] clarify documentation for remote helpers

2019-08-30 Thread David Turner
> -Original Message- > From: Junio C Hamano > Sent: Friday, August 30, 2019 1:35 PM > To: David Turner > Cc: Martin Ågren ; Git Mailing List > > Subject: Re: [PATCH] clarify documentation for remote helpers > > David Turner writes: > > > I was co

Re: [PATCH] clarify documentation for remote helpers

2019-08-30 Thread Junio C Hamano
David Turner writes: > I was confused, because I read "a file under GIT_DIR/objects/pack" > to mean "just the filename". Some of the things that deal with > packs take just the filename (e.g. --keep-pack for git repack). > I'll fix the under under and add $, but I do want to clarify that > it's

RE: [PATCH] clarify documentation for remote helpers

2019-08-30 Thread David Turner
y that it's the full path. > -Original Message- > From: Martin Ågren > Sent: Friday, August 30, 2019 12:03 AM > To: David Turner > Cc: Git Mailing List > Subject: Re: [PATCH] clarify documentation for remote helpers > > On Thu, 29 Aug 2019 at 23:06, David Turner wrote: &

Re: [PATCH] clarify documentation for remote helpers

2019-08-29 Thread Martin Ågren
On Thu, 29 Aug 2019 at 23:06, David Turner wrote: > -Optionally may output a 'lock ' line indicating a file under > -GIT_DIR/objects/pack which is keeping a pack until refs can be > -suitably updated. > +Optionally may output a 'lock ' line indicating the full path of > +a file under under GIT_DI

[PATCH] clarify documentation for remote helpers

2019-08-29 Thread David Turner
Signed-off-by: David Turner --- This doesn't address the connectivity-ok problem, which I continue to worry is a real bug. But it would have saved me a few minutes of debugging. Documentation/gitremote-helpers.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Docume