Re: [PATCH] cherry-pick: do not segfault without arguments.

2013-10-10 Thread Stefan Beller
On 10/10/2013 06:41 PM, Jeff King wrote: > On Fri, Oct 04, 2013 at 04:09:12PM +0200, Stefan Beller wrote: > >> Commit 182d7dc46b (2013-09-05, cherry-pick: allow "-" as abbreviation of >> '@{-1}') accesses the first argument without checking whether it exists. > > I think this is an obviously corr

Re: [PATCH] cherry-pick: do not segfault without arguments.

2013-10-10 Thread Jeff King
On Fri, Oct 04, 2013 at 04:09:12PM +0200, Stefan Beller wrote: > Commit 182d7dc46b (2013-09-05, cherry-pick: allow "-" as abbreviation of > '@{-1}') accesses the first argument without checking whether it exists. I think this is an obviously correct fix for the immediate segfault, but... > diff

[PATCH] cherry-pick: do not segfault without arguments.

2013-10-04 Thread Stefan Beller
Commit 182d7dc46b (2013-09-05, cherry-pick: allow "-" as abbreviation of '@{-1}') accesses the first argument without checking whether it exists. Signed-off-by: Stefan Beller --- builtin/revert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/revert.c b/builtin/rever