Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-28 Thread Barret Rennie
> On Jun 27, 2016, at 5:11 PM, Eric Sunshine wrote: > > [snip] > > My knee-jerk reaction is that the directory name under .git/worktrees > is an implementation detail (and could easily have been an arbitrary > ID, such as .git/worktrees/7ba84ec0) and rather than exposing it > further and encour

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-27 Thread Eric Sunshine
On Mon, Jun 27, 2016 at 1:52 AM, Barret Rennie wrote: > On Jun 26, 2016, at 5:00 PM, Eric Sunshine wrote: >> One thing which hasn't been explained, and about which I'm still >> confused even after reading this thread in its entirety, is what >> Barret means when he says that he "breaks" his workt

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-27 Thread Junio C Hamano
Barret Rennie writes: >> For example, the "frotz" and "nitfol" repositories (i.e. where their >> worktrees borrow their refs and object stores from) could have a >> single configuration variable each, i.e. >> >> (in $HOME/xyzzy/frotz/.git/config) >>[worktree] location = "~/*/frotz"

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-26 Thread Barret Rennie
> On Jun 26, 2016, at 5:00 PM, Eric Sunshine wrote: > > On Sat, Jun 25, 2016 at 3:45 PM, Junio C Hamano wrote: >> [...snip...] >> And explained that way, it becomes clearer that you would want to >> name $HOME/xyzzy-1/frotz worktree after "topic-1", not the default >> name you would get "frotz"

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-26 Thread Barret Rennie
> On Jun 26, 2016, at 12:15 PM, Junio C Hamano wrote: > > Junio C Hamano writes: > >> Now, if you do the worktree, you may still want the relative >> structure between these two, i.e. if you want to work on two >> different branch combinations of the whole thing, you would want to >> do this:

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-26 Thread Eric Sunshine
On Sat, Jun 25, 2016 at 3:45 PM, Junio C Hamano wrote: > [...snip...] > And explained that way, it becomes clearer that you would want to > name $HOME/xyzzy-1/frotz worktree after "topic-1", not the default > name you would get "frotz" (because the default gives you the leaf > level name of the ne

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-26 Thread Junio C Hamano
Junio C Hamano writes: > Now, if you do the worktree, you may still want the relative > structure between these two, i.e. if you want to work on two > different branch combinations of the whole thing, you would want to > do this: > > $HOME/xyzzy-1/frotz - borrow from $HOME/xyzzy/frotz >

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-25 Thread Barret Rennie
> On Jun 25, 2016, at 1:45 PM, Junio C Hamano wrote: > > Barret Rennie writes: > >>> What is "the name for the worktree"? Is it the directory where it lives in? >>> Is it how it is listed with 'git worktree list'? >> >> The name of the worktree is the name of the created directory in >> `.git

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-25 Thread Junio C Hamano
Barret Rennie writes: >> What is "the name for the worktree"? Is it the directory where it lives in? >>Is it how it is listed with 'git worktree list'? > > The name of the worktree is the name of the created directory in > `.git/worktrees`. > >> How is --name different from the argument? > > Cur

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-25 Thread Barret Rennie
Sorry for replying to that message twice. I hit a bug in Apple Mail. --Barret -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-25 Thread Barret Rennie
> What is "the name for the worktree"? Is it the directory where it lives in? >Is it how it is listed with 'git worktree list'? The name of the worktree is the name of the created directory in `.git/worktrees`. > How is --name different from the argument? Currently, if you run:

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-25 Thread Barret Rennie
> What is "the name for the worktree"? Is it the directory where it lives in? >Is it how it is listed with 'git worktree list'? The name of the worktree is the name of the created directory in `.git/worktrees`. > How is --name different from the argument? Currently, if you run:

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-25 Thread Johannes Sixt
Am 25.06.2016 um 07:15 schrieb Barret Rennie: +--name:: + Set the name for the worktree. If there is already a worktree with this What is "the name for the worktree"? Is it the directory where it lives in? Is it how it is listed with 'git worktree list'? How is --name different from th

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-24 Thread Barret Rennie
This is really to scratch an itch I have when I break my worktrees and can’t figure out which worktree dir is the one I’ve broken. For example, I organize my code as follows: projects/reviewboard/branches//src/ django/ djblets/ reviewboard/ for each release branch I ma

Re: [PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-24 Thread Junio C Hamano
Barret Rennie writes: > Add the --name parameter to git worktree add that allows the user to set > the name of the created worktree directory. A worktree must not already > exist with the current name or creation will fail. Hmph. This strongly smells like "because we can add this feature", not

[PATCH] builtin/worktree.c: add option for setting worktree name

2016-06-24 Thread Barret Rennie
Add the --name parameter to git worktree add that allows the user to set the name of the created worktree directory. A worktree must not already exist with the current name or creation will fail. Signed-off-by: Barret Rennie --- Documentation/git-worktree.txt | 6 +- builtin/worktree.c