Re: [PATCH] builtin/config.c: compilation fix

2013-08-08 Thread Junio C Hamano
On Thu, Aug 8, 2013 at 10:38 PM, Kyle J. McKay wrote: >> + const char usage[] = "test-urlmatch-normalization [-p | -l] > Looks good to me except that there seems to be a missing part of the patch. > Did you also mean to include: > > diff --git a/test-urlmatch-normalization.c b/test-urlmatc

Re: [PATCH] builtin/config.c: compilation fix

2013-08-08 Thread Kyle J. McKay
On Aug 8, 2013, at 21:41, Junio C Hamano wrote: Do not feed a random string as the first parameter to die(); use "%s" as the format string instead. Do the same for test-urlmatch-normalization.c while saving a single pointer variable by turning a "const char *" constant string into "const char []

[PATCH] builtin/config.c: compilation fix

2013-08-08 Thread Junio C Hamano
Do not feed a random string as the first parameter to die(); use "%s" as the format string instead. Do the same for test-urlmatch-normalization.c while saving a single pointer variable by turning a "const char *" constant string into "const char []". Signed-off-by: Junio C Hamano --- builtin/co