Re: [PATCH] blame: draft of line format

2017-03-06 Thread Edmundo Carmona Antoranz
On Tue, Jan 31, 2017 at 1:41 PM, Jeff King wrote: > On Mon, Jan 30, 2017 at 08:28:30PM -0600, Edmundo Carmona Antoranz wrote: > >> +static void pretty_info(char* revid, struct blame_entry *ent, struct strbuf >> *rev_buffer) >> +{ >> + struct pretty_print_context ctx = {0}; >> + struct rev

Re: [PATCH] blame: draft of line format

2017-01-31 Thread Jeff King
On Mon, Jan 30, 2017 at 08:28:30PM -0600, Edmundo Carmona Antoranz wrote: > +static void pretty_info(char* revid, struct blame_entry *ent, struct strbuf > *rev_buffer) > +{ > + struct pretty_print_context ctx = {0}; > + struct rev_info rev; > + > + struct strbuf format = STRBUF_INIT;

Re: [PATCH] blame: draft of line format

2017-01-30 Thread Edmundo Carmona Antoranz
I'm basing in on the "pretty API" so that we don't have to reinvent the wheel. I have already noticed that many of the formatting options available for pretty are not working... I'm sure it would require some work setting up the call to pretty api but the basic is laid out there. Let me know of yo

[PATCH] blame: draft of line format

2017-01-30 Thread Edmundo Carmona Antoranz
--- builtin/blame.c | 24 1 file changed, 24 insertions(+) diff --git a/builtin/blame.c b/builtin/blame.c index 126b8c9e5..89c1a862d 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -52,6 +52,7 @@ static int xdl_opts; static int abbrev = -1; static int no_whole_fil