Re: [PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Duy Nguyen
On Sat, Apr 19, 2014 at 12:08 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Fri, Apr 18, 2014 at 3:44 PM, Jiang Xin wrote: >>> When show blame information with relative time, the UTF-8 characters in >>> `time_str` will break the alignment of columns after the date field. >>> This is bec

Re: [PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Junio C Hamano
Duy Nguyen writes: > On Fri, Apr 18, 2014 at 3:44 PM, Jiang Xin wrote: >> When show blame information with relative time, the UTF-8 characters in >> `time_str` will break the alignment of columns after the date field. >> This is because the `time_buf` padding with spaces should have a >> constan

Re: [PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Duy Nguyen
On Fri, Apr 18, 2014 at 3:44 PM, Jiang Xin wrote: > When show blame information with relative time, the UTF-8 characters in > `time_str` will break the alignment of columns after the date field. > This is because the `time_buf` padding with spaces should have a > constant display width, not a fixe

[PATCH] blame: add correct paddings in time_buf for align

2014-04-18 Thread Jiang Xin
When show blame information with relative time, the UTF-8 characters in `time_str` will break the alignment of columns after the date field. This is because the `time_buf` padding with spaces should have a constant display width, not a fixed strlen size. So we should call utf8_strwidth() instead o