Re: [PATCH] add: don't complain when adding empty project root

2014-01-31 Thread Junio C Hamano
Torsten Bögershausen writes: > But, look at > https://www.kernel.org/pub/software/scm/git/docs/git-add.html > > This page seems to need an update too, and I wonder why: > a) The makefile did'nt re-generate html even if it should have > b) That page is not owned or updated by the git.git maintaine

Re: [PATCH] add: don't complain when adding empty project root

2014-01-30 Thread Torsten Bögershausen
[] > filepattern is related to current directory too (e.g. "*.sh" from "t" > won't cover git-rebase.sh, ":/*.sh" does). Yes a patch to update > git-add.txt to use the term "pathspec" instead of "filepattern" would > be nice. A pointer to pathspec glossary could help discover > case-insensitive matc

Re: [PATCH] add: don't complain when adding empty project root

2013-12-26 Thread Junio C Hamano
Junio C Hamano writes: > Regarding "git add --refresh" (no other arguments), it would say > "Nothing specified, nothing added.", and that is unrelated to the > breakage reported and fixed in this thread, I think. It is the same > message "git add" (no other arguments) gives, which I think is a >

Re: [PATCH] add: don't complain when adding empty project root

2013-12-26 Thread Junio C Hamano
Jonathan Nieder writes: > How about something like the following, for squashing in? > > With or without the tweaks below, > Reviewed-by: Jonathan Nieder Thanks, both. Regarding "git add --refresh" (no other arguments), it would say "Nothing specified, nothing added.", and that is unrelated to

Re: [PATCH] add: don't complain when adding empty project root

2013-12-26 Thread Jonathan Nieder
Hi, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy Thanks. [...] > --- a/builtin/add.c > +++ b/builtin/add.c > @@ -544,7 +544,7 @@ int cmd_add(int argc, const char **argv, const char > *prefix) > > for (i = 0; i < pathspec.nr; i++) { >

Re: [PATCH] add: don't complain when adding empty project root

2013-12-24 Thread Duy Nguyen
On Wed, Dec 25, 2013 at 4:48 AM, Torsten Bögershausen wrote: > On 2013-12-24 00.46, Duy Nguyen wrote: >> > [snip] >> We don't complain about adding an empty directory before or after this patch. > Ok, thanks for the explanation. > > I think that > https://www.kernel.org/pub/software/scm/git/docs/g

Re: [PATCH] add: don't complain when adding empty project root

2013-12-24 Thread Torsten Bögershausen
On 2013-12-24 00.46, Duy Nguyen wrote: > [snip] > We don't complain about adding an empty directory before or after this patch. Ok, thanks for the explanation. I think that https://www.kernel.org/pub/software/scm/git/docs/git-add.html could deserve an update. My understanding is that is related

Re: [PATCH] add: don't complain when adding empty project root

2013-12-23 Thread Duy Nguyen
this case "." is project root because current dir is. I could have done "git add -A" (without the dot) like reported, but that will be deprecated soon. Another way to make it clear about project root is use "git add -A :/". I'll send an update if it makes it clearer.

Re: [PATCH] add: don't complain when adding empty project root

2013-12-23 Thread Torsten Bögershausen
ot;git rm --cached ..." to unstage) new file: B Untracked files: (use "git add ..." to include in what will be committed) ../A -------- And the behaviour is in line with https://www.kernel.org/pub/software/scm/git/docs/git-add.html "." s

[PATCH] add: don't complain when adding empty project root

2013-12-23 Thread Nguyễn Thái Ngọc Duy
This behavior was added in 07d7bed (add: don't complain when adding empty project root - 2009-04-28) then broken by 84b8b5d (remove match_pathspec() in favor of match_pathspec_depth() - 2013-07-14). Reinstate it. Noticed-by: Thomas Ferris Nicolaisen Signed-off-by: Nguyễn Thái Ngọc Duy --- built