Re: [PATCH] add: Use struct argv_array in run_add_interactive()

On Sun, Mar 16, 2014 at 7:42 AM, Thomas Rast wrote: > Fabian Ruch writes: > >> run_add_interactive() in builtin/add.c manually computes array bounds >> and allocates a static args array to build the add--interactive command >> line, which is error-prone. Use the argv-array helper functions instea

Re: [PATCH] add: Use struct argv_array in run_add_interactive()

Fabian Ruch writes: > run_add_interactive() in builtin/add.c manually computes array bounds > and allocates a static args array to build the add--interactive command > line, which is error-prone. Use the argv-array helper functions instead. > > Signed-off-by: Fabian Ruch Thanks, this is a nicel

Re: [PATCH] add: Use struct argv_array in run_add_interactive()

On 03/15/2014 12:14 PM, Fabian Ruch wrote: > run_add_interactive() in builtin/add.c manually computes array bounds > and allocates a static args array to build the add--interactive command > line, which is error-prone. Use the argv-array helper functions instead. > > Signed-off-by: Fabian Ruch >

[PATCH] add: Use struct argv_array in run_add_interactive()

run_add_interactive() in builtin/add.c manually computes array bounds and allocates a static args array to build the add--interactive command line, which is error-prone. Use the argv-array helper functions instead. Signed-off-by: Fabian Ruch --- builtin/add.c | 21 ++--- 1 file c