Re: [PATCH] Use ALLOC_GROW() instead of inline code

2014-02-28 4:45 GMT+08:00 Dmitry S. Dolzhenko : > Signed-off-by: Dmitry S. Dolzhenko > --- > attr.c | 7 +-- > builtin/pack-objects.c | 7 +-- > bundle.c | 6 +- > cache-tree.c | 6 +- > commit.c | 8 ++-- > diff.c

Re: [PATCH] Use ALLOC_GROW() instead of inline code

"Dmitry S. Dolzhenko" writes: > diff --git a/dir.c b/dir.c > index b35b633..72f6e2a 100644 > --- a/dir.c > +++ b/dir.c > @@ -1329,13 +1329,10 @@ static struct path_simplify *create_simplify(const > char **pathspec) > > for (nr = 0 ; ; nr++) { > const char *match; > -

Re: [PATCH] Use ALLOC_GROW() instead of inline code

Dmitry, That's cool; I never imagined there would be so many sites that could be cleaned up in this way. In my opinion, it would be preferable for this patch to be broken into multiple commits, one for each site (or each file, if a file has multiple sites that are logically related). That would

[PATCH] Use ALLOC_GROW() instead of inline code

Signed-off-by: Dmitry S. Dolzhenko --- attr.c | 7 +-- builtin/pack-objects.c | 7 +-- bundle.c | 6 +- cache-tree.c | 6 +- commit.c | 8 ++-- diff.c | 12 ++-- diffcore-rename.c | 12 ++--