Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-29 Thread Junio C Hamano
Matthieu Moy writes: >> I also agree that droppage of S does not have to wait for that >> topic. > > So, shall I rewrite my patch on top of master? (not hard, but there will > be a minor conflict to resolve when merging with Peff's cooking series). Sure, the one near the tip of 'pu' can even be

Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-29 Thread Matthieu Moy
Junio C Hamano writes: > Jeff King writes: > >> On Mon, Apr 28, 2014 at 02:22:21PM +0200, Matthieu Moy wrote: >> >> I'd be OK with doing the moral equivalent for now (perhaps just taking >> Junio's proposal[1]), and I can deal with the refactoring later when >> re-rolling the Makefile series. >>

Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-28 Thread Junio C Hamano
Jeff King writes: > On Mon, Apr 28, 2014 at 02:22:21PM +0200, Matthieu Moy wrote: > > I'd be OK with doing the moral equivalent for now (perhaps just taking > Junio's proposal[1]), and I can deal with the refactoring later when > re-rolling the Makefile series. > > -Peff > > [1] http://article.gm

Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-28 Thread Jeff King
On Mon, Apr 28, 2014 at 02:22:21PM +0200, Matthieu Moy wrote: > >> Not since f82c3ffd862c7 (Wed Feb 5 2014, move LESS/LV pager environment > >> to Makefile). > > > > The only upstream branch containing this commit is pu. So this patch > > should likely not go anywhere else for now. > > Oops, ind

Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-28 Thread Matthieu Moy
David Kastrup writes: > Matthieu Moy writes: > >> David Kastrup writes: >> >>> There seem to be a few more occurences (git-sh-setup.sh and pager.c): >> >> Not since f82c3ffd862c7 (Wed Feb 5 2014, move LESS/LV pager environment >> to Makefile). > > The only upstream branch containing this commit

Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-28 Thread David Kastrup
Matthieu Moy writes: > David Kastrup writes: > >> There seem to be a few more occurences (git-sh-setup.sh and pager.c): > > Not since f82c3ffd862c7 (Wed Feb 5 2014, move LESS/LV pager environment > to Makefile). The only upstream branch containing this commit is pu. So this patch should likely

Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-28 Thread Matthieu Moy
David Kastrup writes: > There seem to be a few more occurences (git-sh-setup.sh and pager.c): Not since f82c3ffd862c7 (Wed Feb 5 2014, move LESS/LV pager environment to Makefile). > Searching for LESS seems to implicate a few more possible candidates in > contrib/examples: > > contrib/examples/

Re: [PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-28 Thread David Kastrup
Matthieu Moy writes: > By default, Git used to set $LESS to -FRSX if $LESS was not set by the > user. The FRX flags actually make sense for Git (F and X because Git > sometimes pipes short output to less, and R because Git pipes colored > output). The S flag (chop long lines), on the other hand,

[PATCH] PAGER_ENV: remove 'S' from $LESS by default

2014-04-28 Thread Matthieu Moy
By default, Git used to set $LESS to -FRSX if $LESS was not set by the user. The FRX flags actually make sense for Git (F and X because Git sometimes pipes short output to less, and R because Git pipes colored output). The S flag (chop long lines), on the other hand, is not related to Git and is a