Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-09 Thread Junio C Hamano
Junio C Hamano writes: > Johannes Schindelin writes: > >> In any case, it does not break things, and it helps Cygwin, so: ACK >> >> Ciao, >> Dscho >> >> P.S.: I pushed this to Git for Windows' `master`, too: >> https://github.com/git-for-windows/git/commit/f05a26948b > > Hmm, I peeked it hoping

Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-09 Thread Junio C Hamano
Johannes Schindelin writes: > In any case, it does not break things, and it helps Cygwin, so: ACK > > Ciao, > Dscho > > P.S.: I pushed this to Git for Windows' `master`, too: > https://github.com/git-for-windows/git/commit/f05a26948b Hmm, I peeked it hoping that you corrected the log message alo

Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-09 Thread Junio C Hamano
Johannes Schindelin writes: > ... > It is a bit curious that -lws2_32 *does* only show up in $(LIBS), but I > guess it is simply the fact that we use a newer GCC (gcc.exe (Rev2, Built > by MSYS2 project) 6.2.0) that allows Git for Windows to be built even > without this patch. > > In any case, it

Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-09 Thread Johannes Schindelin
Hi Junio, On Sun, 8 Jan 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > > On Sun, 8 Jan 2017, Steven Penny wrote: > > > >> On Sun, Jan 8, 2017 at 5:54 AM, Johannes Schindelin wrote: > >> > I am curious: how do you build Git? I ask because I build Git on > >> > Windows many times a

Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-08 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Steven, > > On Sun, 8 Jan 2017, Steven Penny wrote: > >> On Sun, Jan 8, 2017 at 5:54 AM, Johannes Schindelin wrote: >> > I am curious: how do you build Git? I ask because I build Git on Windows >> > many times a day, and I did not encounter any link problems. >>

Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-08 Thread Johannes Schindelin
Hi Steven, On Sun, 8 Jan 2017, Steven Penny wrote: > On Sun, Jan 8, 2017 at 5:54 AM, Johannes Schindelin wrote: > > I am curious: how do you build Git? I ask because I build Git on Windows > > many times a day, and I did not encounter any link problems. > > My end goal is to build static native

Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-08 Thread Steven Penny
On Sun, Jan 8, 2017 at 5:54 AM, Johannes Schindelin wrote: > I am curious: how do you build Git? I ask because I build Git on Windows > many times a day, and I did not encounter any link problems. My end goal is to build static native Windows Git via Cygwin and the mingw64-x86_64-gcc-core package.

Re: [PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-08 Thread Johannes Schindelin
Hi Steven, On Sun, 8 Jan 2017, Steven Penny wrote: > This matches up with the targets git-%, git-http-fetch, git-http-push > and git-remote-testsvn. It must be done this way on Windows else lcrypto > cannot find lgdi32 and lws2_32 I am curious: how do you build Git? I ask because I build Git on

[PATCH] Makefile: put LIBS after LDFLAGS for imap-send

2017-01-07 Thread Steven Penny
This matches up with the targets git-%, git-http-fetch, git-http-push and git-remote-testsvn. It must be done this way on Windows else lcrypto cannot find lgdi32 and lws2_32 Signed-off-by: Steven Penny --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Ma