Re: [PATCH] Makefile: fix default regex settings on Darwin

2013-05-11 Thread David Aguilar
On Sat, May 11, 2013 at 12:04 AM, Jonathan Nieder wrote: > David Aguilar wrote: > >> expecting success: >> # if this test fails, re-build git with NO_REGEX=1 >> test-regex >> >> fatal: regex bug confirmed: re-build git with NO_REGEX=1 > > Thanks. Gah. That means that regcomp() with REG_NEWLINE i

Re: [PATCH] Makefile: fix default regex settings on Darwin

2013-05-11 Thread Jonathan Nieder
David Aguilar wrote: > expecting success: > # if this test fails, re-build git with NO_REGEX=1 > test-regex > > fatal: regex bug confirmed: re-build git with NO_REGEX=1 Thanks. Gah. That means that regcomp() with REG_NEWLINE is letting [^={} \t]+ match the newline in ={}\nfre

Re: [PATCH] Makefile: fix default regex settings on Darwin

2013-05-10 Thread David Aguilar
On Fri, May 10, 2013 at 11:31 PM, Jonathan Nieder wrote: > David Aguilar wrote: > >> t0070-fundamental.sh fails on Mac OS X 10.8 by default. >> Fix it by using Git's regex library. > > Can you say more about the failure? What does > > ./t0070-fundamental.sh -v > > say? [..snip...] expec

Re: [PATCH] Makefile: fix default regex settings on Darwin

2013-05-10 Thread Jonathan Nieder
David Aguilar wrote: > t0070-fundamental.sh fails on Mac OS X 10.8 by default. > Fix it by using Git's regex library. Can you say more about the failure? What does ./t0070-fundamental.sh -v say? Curious, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the

[PATCH] Makefile: fix default regex settings on Darwin

2013-05-10 Thread David Aguilar
t0070-fundamental.sh fails on Mac OS X 10.8 by default. Fix it by using Git's regex library. Signed-off-by: David Aguilar --- "make test" fails right now; this fixes it. t0070-fundamental is how far it got last time. It's still running now.. :-) Makefile | 1 + 1 file changed, 1 insertion(+) d