Re: [PATCH] Make test output coloring more intuitive

2012-09-19 Thread Jeff King
On Wed, Sep 19, 2012 at 09:12:01PM +0100, Adam Spiers wrote: > > > Sounds reasonable, and I think the new output looks nice. I notice that > > > skipped tests are still in green. I wonder if they should be in yellow, > > > too. > > > > > What about blue instead? This would keep the colouring sch

Re: [PATCH] Make test output coloring more intuitive

2012-09-19 Thread Adam Spiers
On Wed, Sep 19, 2012 at 10:02:52PM +0200, Stefano Lattarini wrote: > On 09/17/2012 10:11 PM, Jeff King wrote: > > On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote: > > > >> The end result of these changes is that: > >> > >> - red is _only_ used for things which have gone unexpectedly

Re: [PATCH] Make test output coloring more intuitive

2012-09-19 Thread Stefano Lattarini
On 09/17/2012 10:11 PM, Jeff King wrote: > On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote: > >> The end result of these changes is that: >> >> - red is _only_ used for things which have gone unexpectedly wrong: >> test failures, unexpected test passes, and failures with the >>

Re: [PATCH] Make test output coloring more intuitive

2012-09-18 Thread Adam Spiers
On Tue, Sep 18, 2012 at 10:59 PM, Jeff King wrote: > TODO is a special token[1] respected by TAP harnesses like "prove". I'm > not sure what practical impact it has, but it should probably remain. > > -Peff > > [1] http://testanything.org/wiki/index.php/TAP_specification#TODO_tests Thanks, I didn

Re: [PATCH] Make test output coloring more intuitive

2012-09-18 Thread Jeff King
On Tue, Sep 18, 2012 at 10:36:17PM +0100, Adam Spiers wrote: > > > + say_color error "ok $test_count - $@ # TODO known breakage vanished" > > > } > > > > Also I wonder if this is still a "TODO". > > Hah, I should trust my first instincts more; my first version of the > patch dropped the "TODO",

Re: [PATCH] Make test output coloring more intuitive

2012-09-18 Thread Adam Spiers
On Mon, Sep 17, 2012 at 01:50:39PM -0700, Junio C Hamano wrote: > Adam Spiers writes: > > > 1. Change the color of individual known breakages from bold green to > >bold yellow. This seems more appropriate when considering the > >universal traffic lights coloring scheme, where green conve

Re: [PATCH] Make test output coloring more intuitive

2012-09-18 Thread Adam Spiers
On Mon, Sep 17, 2012 at 04:11:19PM -0400, Jeff King wrote: > On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote: > > > The end result of these changes is that: > > > > - red is _only_ used for things which have gone unexpectedly wrong: > > test failures, unexpected test passes, and

Re: [PATCH] Make test output coloring more intuitive

2012-09-17 Thread Junio C Hamano
Adam Spiers writes: > 1. Change the color of individual known breakages from bold green to >bold yellow. This seems more appropriate when considering the >universal traffic lights coloring scheme, where green conveys the >impression that everything's OK, and amber that something's no

Re: [PATCH] Make test output coloring more intuitive

2012-09-17 Thread Jeff King
On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote: > The end result of these changes is that: > > - red is _only_ used for things which have gone unexpectedly wrong: > test failures, unexpected test passes, and failures with the > framework, > > - yellow is _only_ used for

[PATCH] Make test output coloring more intuitive

2012-09-17 Thread Adam Spiers
1. Change the color of individual known breakages from bold green to bold yellow. This seems more appropriate when considering the universal traffic lights coloring scheme, where green conveys the impression that everything's OK, and amber that something's not quite right. 2. Likewise