Re: [PATCH] Make !pattern in .gitattributes non-fatal

2013-03-02 Thread Junio C Hamano
Duy Nguyen writes: > This "return NULL;" means we ignore "!blah" pattern, which is a > regression, isn't it? Should we treat '!' as literal here? Probably not. Can you point to a project everybody has heard of that keeps track of a path that begins with an exclamation point? With clarification

Re: [PATCH] Make !pattern in .gitattributes non-fatal

2013-03-01 Thread Duy Nguyen
On Sat, Mar 2, 2013 at 3:06 AM, Thomas Rast wrote: > Before 82dce99 (attr: more matching optimizations from .gitignore, > 2012-10-15), .gitattributes did not have any special treatment of a > leading '!'. The docs, however, always said > > The rules how the pattern matches paths are the same as

Re: [PATCH] Make !pattern in .gitattributes non-fatal

2013-03-01 Thread Junio C Hamano
Thomas Rast writes: > Junio C Hamano writes: > >> Thomas Rast writes: >> >>> Before 82dce99 (attr: more matching optimizations from .gitignore, >>> 2012-10-15), .gitattributes did not have any special treatment of a >>> leading '!'. The docs, however, always said >>> >>> The rules how the pa

Re: [PATCH] Make !pattern in .gitattributes non-fatal

2013-03-01 Thread Thomas Rast
Junio C Hamano writes: > Thomas Rast writes: > >> Before 82dce99 (attr: more matching optimizations from .gitignore, >> 2012-10-15), .gitattributes did not have any special treatment of a >> leading '!'. The docs, however, always said >> >> The rules how the pattern matches paths are the same

Re: [PATCH] Make !pattern in .gitattributes non-fatal

2013-03-01 Thread Junio C Hamano
Thomas Rast writes: > Before 82dce99 (attr: more matching optimizations from .gitignore, > 2012-10-15), .gitattributes did not have any special treatment of a > leading '!'. The docs, however, always said > > The rules how the pattern matches paths are the same as in > `.gitignore` files; se

Re: [PATCH] Make !pattern in .gitattributes non-fatal

2013-03-01 Thread Junio C Hamano
Makes sense. Duy? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Make !pattern in .gitattributes non-fatal

2013-03-01 Thread Thomas Rast
Before 82dce99 (attr: more matching optimizations from .gitignore, 2012-10-15), .gitattributes did not have any special treatment of a leading '!'. The docs, however, always said The rules how the pattern matches paths are the same as in `.gitignore` files; see linkgit:gitignore[5]. By those