Re: Re* [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-03 Thread Heiko Voigt
Hi, On Tue, Dec 03, 2013 at 10:39:36AM -0800, Junio C Hamano wrote: > OK, thanks, then let's do this. Yes, sounds good. Cheers Heiko > -- >8 -- > From: Nick Townsend > Date: Mon, 25 Nov 2013 15:31:09 -0800 > Subject: [PATCH] ref-iteration doc: add_submodule_odb() returns 0 for success > > The

Re* [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-03 Thread Junio C Hamano
Heiko Voigt writes: > On Mon, Dec 02, 2013 at 04:14:37PM -0800, Nick Townsend wrote: >> diff --git a/submodule.c b/submodule.c >> index 1905d75..1ea46be 100644 >> --- a/submodule.c >> +++ b/submodule.c >> @@ -143,7 +143,7 @@ void stage_updated_gitmodules(void) >> die(_("staging updat

Re: Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-03 Thread Heiko Voigt
On Mon, Dec 02, 2013 at 04:14:37PM -0800, Nick Townsend wrote: > diff --git a/submodule.c b/submodule.c > index 1905d75..1ea46be 100644 > --- a/submodule.c > +++ b/submodule.c > @@ -143,7 +143,7 @@ void stage_updated_gitmodules(void) > die(_("staging updated .gitmodules failed")); >

Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-03 Thread Junio C Hamano
Eric Sunshine writes: >> +test_expect_success 'archive subtree from subdir' ' >> + cd a && >> + git archive --format=tar HEAD >../asubtree.tar && >> + cd .. && >> + make_dir extract && >> + "$TAR" xf asubtree.tar -C extract && >> + check_dir extract af b b/bf b

Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-03 Thread Junio C Hamano
Nick Townsend writes: > From: Nick Townsend > Date: Mon, 25 Nov 2013 15:31:09 -0800 > Subject: [PATCH 1/2] submodule: add_submodule_odb() usability Please do not add these; instead, drop From/Date (because we can see them in the mail header from your MUA) and replace the mail header Subject wit

Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-03 Thread Eric Sunshine
On Mon, Dec 2, 2013 at 7:16 PM, Nick Townsend wrote: > From: Nick Townsend > Date: Sat, 30 Nov 2013 16:54:20 -0800 > Subject: [PATCH 2/2] Additional git-archive tests > > Interplay between paths specified in three ways now tested: > * After a : in the tree-ish, > * As a pathspec in the command, >

Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-02 Thread Nick Townsend
From: Nick Townsend Date: Sat, 30 Nov 2013 16:54:20 -0800 Subject: [PATCH 2/2] Additional git-archive tests Interplay between paths specified in three ways now tested: * After a : in the tree-ish, * As a pathspec in the command, * By virtue of the current working directory Note that these tests

Re: [PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-02 Thread Nick Townsend
From: Nick Townsend Date: Mon, 25 Nov 2013 15:31:09 -0800 Subject: [PATCH 1/2] submodule: add_submodule_odb() usability Although add_submodule_odb() is documented as being externally usable, it is declared static and also has incorrect documentation. This commit fixes those and makes no changes

[PATCH] Improvements to git-archive tests and add_submodule_odb()

2013-12-02 Thread Nick Townsend
As per the previous patch request, I’ve delayed the work on git-archive. However the following two patches (attached as replies) should still be considered. Kind Regards Nick-- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More