Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
On Mon, Jul 30, 2012 at 3:09 PM, Junio C Hamano wrote: > Daniel Graña writes: > >> * Check submodule is correctly initialized and updated after cloning >> .dotfiles >> >> Signed-off-by: Daniel Graña >> --- > > Thanks. > >> @@ -23,14 +27,27 @@ test_expect_success 'submodule on detached working t

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Junio C Hamano
Daniel Graña writes: > * Check submodule is correctly initialized and updated after cloning .dotfiles > > Signed-off-by: Daniel Graña > --- Thanks. > @@ -23,14 +27,27 @@ test_expect_success 'submodule on detached working tree' ' > git clone --bare ../remote .dotfiles && >

[PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
* Check submodule is correctly initialized and updated after cloning .dotfiles Signed-off-by: Daniel Graña --- t/t7409-submodule-detached-worktree.sh | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/t/t7409-submodule-detached-worktree.sh b/

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Junio C Hamano
Junio C Hamano writes: > Daniel Graña writes: > ... >> is it still better than "git rev-parse --max-count=1 HEAD" seen in >> t7406-submodule.update.sh? > > "git rev-parse --max-count=1 HEAD" will show "--max-count=1\n" > followed by the value of HEAD, so if the expected result and the > actual r

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
On Mon, Jul 30, 2012 at 2:43 PM, Daniel Graña wrote: > * Check submodule is correctly initialized and updated after cloning .dotfiles > > Signed-off-by: Daniel Graña > --- Ignore this patch, I am sending another without extra space after standard output redirection. > > Remove $TRASH_DIRECTOR

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Junio C Hamano
Daniel Graña writes: > On Mon, Jul 30, 2012 at 2:02 PM, Junio C Hamano wrote: >> Daniel Graña writes: >> >>> Signed-off-by: Daniel Graña >>> --- >>> t/t7409-submodule-detached-worktree.sh | 31 >>> --- >>> 1 files changed, 24 insertions(+), 7 deletions(-) >>> >>

[PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
* Check submodule is correctly initialized and updated after cloning .dotfiles Signed-off-by: Daniel Graña --- Remove $TRASH_DIRECTORY and "git rev-parse --verify HEAD" as suggested by Junio t/t7409-submodule-detached-worktree.sh | 31 --- 1 files changed, 24 inse

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
On Mon, Jul 30, 2012 at 2:02 PM, Junio C Hamano wrote: > Daniel Graña writes: > >> Signed-off-by: Daniel Graña >> --- >> t/t7409-submodule-detached-worktree.sh | 31 >> --- >> 1 files changed, 24 insertions(+), 7 deletions(-) >> >> diff --git a/t/t7409-submodule-d

Fwd: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
Forwardning for the record as vger rejected my previous HTML email. -- Forwarded message -- From: Daniel Graña Date: Mon, Jul 30, 2012 at 2:04 PM Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule To: Jeff King Cc: Junio C Hamano , git@vger.kernel.org Hi

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Junio C Hamano
Daniel Graña writes: > Signed-off-by: Daniel Graña > --- > t/t7409-submodule-detached-worktree.sh | 31 --- > 1 files changed, 24 insertions(+), 7 deletions(-) > > diff --git a/t/t7409-submodule-detached-worktree.sh > b/t/t7409-submodule-detached-worktree.sh > ind

Re: [PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Jeff King
On Mon, Jul 30, 2012 at 01:10:10PM -0300, Daniel Graña wrote: > Subject: Re: [PATCH] Improve tests for detached worktree in git-submodule > > Signed-off-by: Daniel Graña The space between the subject and your S-o-b is an excellent place to explain the rationale for your commit. H

[PATCH] Improve tests for detached worktree in git-submodule

2012-07-30 Thread Daniel Graña
Signed-off-by: Daniel Graña --- t/t7409-submodule-detached-worktree.sh | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/t/t7409-submodule-detached-worktree.sh b/t/t7409-submodule-detached-worktree.sh index db75642..d88f400 100755 --- a/t/t7