Re: [PATCH] GSoC2014 Microproject rewrite finish_bulk_checkin()

2014-02-27 Thread Faiz Kothari
Hi, Thanks for the remarks. I'll stick to this micro project and follow the guidelines. Yes, the strbuf API is perfectly OK. I was not getting to work it properly, so I used malloc() / free() instead. My bad. I'll resubmit the patch. Thanks. On Fri, Feb 28, 2014 at 3:47 AM, Michael Haggerty wrote

Re: [PATCH] GSoC2014 Microproject rewrite finish_bulk_checkin()

2014-02-27 Thread Michael Haggerty
On 02/27/2014 08:02 PM, Faiz Kothari wrote: > Signed-off-by: Faiz Kothari > --- > bulk-checkin.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/bulk-checkin.c b/bulk-checkin.c > index 118c625..feeff9f 100644 > --- a/bulk-checkin.c > +++ b/bulk-checkin.c >

[PATCH] GSoC2014 Microproject rewrite finish_bulk_checkin()

2014-02-27 Thread Faiz Kothari
Signed-off-by: Faiz Kothari --- bulk-checkin.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/bulk-checkin.c b/bulk-checkin.c index 118c625..feeff9f 100644 --- a/bulk-checkin.c +++ b/bulk-checkin.c @@ -23,7 +23,7 @@ static struct bulk_checkin_state { static vo