Re: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()

2014-03-21 Thread Ashwin Jha
On 03/22/2014 12:11 AM, Eric Sunshine wrote: On Fri, Mar 21, 2014 at 5:18 AM, Ashwin Jha wrote: On Fri, Mar 21, 2014 at 9:03 AM, Eric Sunshine wrote: On Thu, Mar 20, 2014 at 9:54 PM, Ashwin Jha wrote: Subject: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit() starts_with() seems

Re: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()

2014-03-21 Thread Eric Sunshine
On Fri, Mar 21, 2014 at 5:18 AM, Ashwin Jha wrote: > On Fri, Mar 21, 2014 at 9:03 AM, Eric Sunshine > wrote: >> On Thu, Mar 20, 2014 at 9:54 PM, Ashwin Jha wrote: >> > Subject: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit() >> > starts_with() seems

Re: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()

2014-03-21 Thread Ashwin Jha
Original Message Subject:[PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit() Date: Fri, 21 Mar 2014 07:24:46 +0530 From: Ashwin Jha To: git@vger.kernel.org CC: Ashwin Jha modified fsck.c:fsck_commit(). Replaced memcmp() with starts_with() function

Re: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()

2014-03-20 Thread Eric Sunshine
Thanks for the submission. Comments below to give you a feel for the Git review process... On Thu, Mar 20, 2014 at 9:54 PM, Ashwin Jha wrote: > Subject: [PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit() The subject becomes part of the permanent Git history, but the fact that this i

[PATCH] GSoC Miniproject 15. Rewrite fsck.c:fsck_commit()

2014-03-20 Thread Ashwin Jha
modified fsck.c:fsck_commit(). Replaced memcmp() with starts_with() function. starts_with() seems much more relevant than memcmp(). It uses one less argument and its return value makes more sense. skip_prefix() is not used as it uses strcmp() internally which seems unnecessarily for current task.